Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update status design with NAR and delete #70

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mateusoliveira43
Copy link
Contributor

Why the changes were made

Follow up of #23 to:

How to test the changes made

Read design and see if it is clear and the code follows it.

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Copy link

openshift-ci bot commented May 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

Copy link

openshift-ci bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -738,6 +738,150 @@ spec:
file in object storage.
type: integer
type: object
veleroObject:
Copy link
Contributor Author

@mateusoliveira43 mateusoliveira43 May 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reading design I though about this: creating a struct that contains all velero things

  • name
  • namespace
  • status

called veleroObject but it could be veleroBackup and veleroRestore for NAB and NAR respectively

What you think?

if you like, will delete veleroBackupName, veleroBackupNamespace and veleroBackupStatus from NonAdminBackupStatus; otherwise, I delete the added code

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant