-
-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: adjust two rules to imitate Standard #166
Conversation
mightyiam
commented
Nov 12, 2019
- Fixes indent rule missing ignoredNodes #164
- Fixes no-unused-vars missing ignoreRestSiblings #165
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 from me.
Anyone else please?
@@ -47,7 +47,8 @@ test('export', (t): void => { | |||
ObjectExpression: 1, | |||
ImportDeclaration: 1, | |||
flatTernaryExpressions: false, | |||
ignoreComments: false | |||
ignoreComments: false, | |||
ignoredNodes: ['TemplateLiteral *'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -32,11 +32,12 @@ export = { | |||
ObjectExpression: 1, | |||
ImportDeclaration: 1, | |||
flatTernaryExpressions: false, | |||
ignoreComments: false | |||
ignoreComments: false, | |||
ignoredNodes: ['TemplateLiteral *'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -68,7 +69,7 @@ test('export', (t): void => { | |||
'@typescript-eslint/no-non-null-assertion': 'error', | |||
'@typescript-eslint/no-this-alias': ['error', { allowDestructuring: true }], | |||
'@typescript-eslint/no-unnecessary-type-assertion': 'error', | |||
'@typescript-eslint/no-unused-vars': ['error', { args: 'none' }], | |||
'@typescript-eslint/no-unused-vars': ['error', { args: 'none', ignoreRestSiblings: true }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
}], | ||
'@typescript-eslint/no-array-constructor': 'error', | ||
'@typescript-eslint/no-empty-function': 'error', | ||
'@typescript-eslint/no-unused-vars': ['error', { args: 'none' }], | ||
'@typescript-eslint/no-unused-vars': ['error', { args: 'none', ignoreRestSiblings: true }], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just going to plow ahead with this. |