Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade typescript-eslint packages to v2.1 #161

Merged
merged 1 commit into from
Nov 12, 2019
Merged

Conversation

mightyiam
Copy link
Owner

Closes #152.

Copy link
Owner Author

@mightyiam mightyiam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Waiting for another review, please.

@@ -56,7 +58,8 @@ export = {
'@typescript-eslint/explicit-function-return-type': ['error', {
allowExpressions: true,
allowHigherOrderFunctions: true,
allowTypedFunctionExpressions: true
allowTypedFunctionExpressions: true,
allowDirectConstAssertionInArrowFunctions: true
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typescript-eslint/typescript-eslint#876
I feel that it's a welcome relaxation of the rule. I don't see any downside to it.

@@ -40,6 +41,7 @@ export = {
'@typescript-eslint/no-unused-vars': ['error', { args: 'none' }],
'@typescript-eslint/no-use-before-define': ['error', { functions: false, classes: false, variables: false, typedefs: false }],
'@typescript-eslint/no-useless-constructor': 'error',
'@typescript-eslint/quotes': ['error', 'single', { avoidEscape: true, allowTemplateLiterals: false }],
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mightyiam mightyiam merged commit 2e7a4e4 into master Nov 12, 2019
@mightyiam mightyiam deleted the plugin-2.1.0 branch November 12, 2019 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update plugin to 2.1.0 (2019-09-02)
2 participants