Add secretsManager middleware #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e set in the context - changed places where mockReset is used where it should be mockClear (since we just want to reset the invocation count) - cache the SSM response, and apply the cached params even when skip calling SSM
Codecov Report
@@ Coverage Diff @@
## master #227 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 18 19 +1
Lines 455 492 +37
Branches 93 100 +7
=====================================
+ Hits 455 492 +37
Continue to review full report at Codecov.
|
lmammino
approved these changes
Aug 25, 2018
|
Thanks! Yes, would put a PR for the 1.0.0 branch as well (know the drill by now :-P) |
|
|
||
| ### Sample Usage | ||
|
|
||
| Simplest usage, exports parameters as environment variables. |
There was a problem hiding this comment.
exports parameters as environment variables.
Copy-paste from SSM middleware?) Looks like no option to export as environment variable in this middleware, only context object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added middleware for
secretsManagerwith corresponding tests and README changes.Addresses #151