Skip to content

Commit

Permalink
test: rewrite "packages/http-header-normalizer" tests to async/await
Browse files Browse the repository at this point in the history
fixes #270
  • Loading branch information
vladholubiev committed Sep 5, 2019
1 parent 44ffa80 commit 65013ee
Showing 1 changed file with 21 additions and 28 deletions.
49 changes: 21 additions & 28 deletions packages/http-header-normalizer/__tests__/index.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
const { invoke } = require('../../test-helpers')
const middy = require('../../core')
const httpHeaderNormalizer = require('../')

describe('👺 Middleware Http Header Normalizer', () => {
test('It should normalize (lowercase) all the headers and create a copy in rawHeaders', (endTest) => {
test('It should normalize (lowercase) all the headers and create a copy in rawHeaders', async () => {
const handler = middy((event, context, cb) => cb(null, event))

handler
Expand All @@ -28,15 +29,13 @@ describe('👺 Middleware Http Header Normalizer', () => {

const originalHeaders = Object.assign({}, event.headers)

// run the handler
handler(event, {}, (_, resultingEvent) => {
expect(resultingEvent.headers).toEqual(expectedHeaders)
expect(resultingEvent.rawHeaders).toEqual(originalHeaders)
endTest()
})
const resultingEvent = await invoke(handler, event)

expect(resultingEvent.headers).toEqual(expectedHeaders)
expect(resultingEvent.rawHeaders).toEqual(originalHeaders)
})

test('It should normalize (canonical) all the headers and create a copy in rawHeaders', (endTest) => {
test('It should normalize (canonical) all the headers and create a copy in rawHeaders', async () => {
const handler = middy((event, context, cb) => cb(null, event))

handler
Expand All @@ -62,15 +61,13 @@ describe('👺 Middleware Http Header Normalizer', () => {

const originalHeaders = Object.assign({}, event.headers)

// run the handler
handler(event, {}, (_, resultingEvent) => {
expect(resultingEvent.headers).toEqual(expectedHeaders)
expect(resultingEvent.rawHeaders).toEqual(originalHeaders)
endTest()
})
const resultingEvent = await invoke(handler, event)

expect(resultingEvent.headers).toEqual(expectedHeaders)
expect(resultingEvent.rawHeaders).toEqual(originalHeaders)
})

test('It can use custom normalization function', (endTest) => {
test('It can use custom normalization function', async () => {
const normalizeHeaderKey = (key) => key.toUpperCase()

const handler = middy((event, context, cb) => cb(null, event))
Expand Down Expand Up @@ -100,15 +97,13 @@ describe('👺 Middleware Http Header Normalizer', () => {

const originalHeaders = Object.assign({}, event.headers)

// run the handler
handler(event, {}, (_, resultingEvent) => {
expect(resultingEvent.headers).toEqual(expectedHeaders)
expect(resultingEvent.rawHeaders).toEqual(originalHeaders)
endTest()
})
const resultingEvent = await invoke(handler, event)

expect(resultingEvent.headers).toEqual(expectedHeaders)
expect(resultingEvent.rawHeaders).toEqual(originalHeaders)
})

test('It should not fail if the event does not contain headers', (endTest) => {
test('It should not fail if the event does not contain headers', async () => {
const handler = middy((event, context, cb) => cb(null, event))

handler
Expand All @@ -122,11 +117,9 @@ describe('👺 Middleware Http Header Normalizer', () => {
foo: 'bar'
}

// run the handler
handler(event, {}, (_, resultingEvent) => {
expect(resultingEvent).toEqual(expectedEvent)
expect(resultingEvent.rawHeaders).toBeUndefined()
endTest()
})
const resultingEvent = await invoke(handler, event)

expect(resultingEvent).toEqual(expectedEvent)
expect(resultingEvent.rawHeaders).toBeUndefined()
})
})

0 comments on commit 65013ee

Please sign in to comment.