Clean up diff editor reference when no longer in use #230713
Open
+8
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have found out that the
monaco-editor
diff editor was not releasing the memory when it was removed from the DOM.With further testing I narrowed down the issue to the
diffEditorWidget.ts
file where thecodeEditorService
is keeping a reference to the diff editor.I've tested the proposed solution by applying a npm patch to
monaco-editor
. And running the code mentioned in the issue.Fixes: microsoft/monaco-editor#4659