Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository Container: Offer to create devcontainer.json when it does not exist #1570

Closed
chrmarti opened this issue Oct 2, 2019 · 3 comments
Assignees
Labels
verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@chrmarti
Copy link
Contributor

chrmarti commented Oct 2, 2019

#1515

Using a repository that does not have a devcontainer.json ends with an error dialog. It would be great if we instead offered to create the devcontainer.json with the QuickPick sequence we already have. (E.g., use 'microsoft/python-sample-vscode-flask-tutorial').

@chrmarti
Copy link
Contributor Author

chrmarti commented Oct 2, 2019

Variations to this could be:

  • Associate a local devcontainer.json instead of copying the definition into the project folder to avoid polluting the repository.
  • Associate a local DevContainer definition that is readonly (and updates with updates to the Remote-Containers extension).

@egamma
Copy link
Member

egamma commented Mar 29, 2020

Support to add a dev container configuration when it doesn't exist has been added.

I've extracted the ideas from #1570 (comment) into a separate issue.

To verify:

You will prompted with the dev container definitions quick pick.

@egamma egamma closed this as completed Mar 29, 2020
@egamma egamma added the verification-needed Verification of issue is requested label Mar 29, 2020
@egamma egamma added this to the March 2020 milestone Mar 30, 2020
@egamma
Copy link
Member

egamma commented Mar 31, 2020

To verify:

There is a bug on Window that was fixed in the latest. To verify you need extension version > 0.109

@roblourens roblourens added the verified Verification succeeded label Apr 2, 2020
@vscodebot vscodebot bot locked and limited conversation to collaborators May 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants