Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix startup telemetry issue #21203

Merged
merged 1 commit into from
May 9, 2023
Merged

Fix startup telemetry issue #21203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/client/startupTelemetry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,9 @@ async function getActivationTelemetryProps(serviceContainer: IServiceContainer):
return { workspaceFolderCount, terminal: terminalShellType };
}
const interpreterService = serviceContainer.get<IInterpreterService>(IInterpreterService);
const mainWorkspaceUri = workspaceService.workspaceFolders ? workspaceService.workspaceFolders[0].uri : undefined;
const mainWorkspaceUri = workspaceService.workspaceFolders?.length
? workspaceService.workspaceFolders[0].uri
: undefined;
const hasPythonThree = await interpreterService.hasInterpreters(async (item) => item.version?.major === 3);
// If an unknown type environment can be found from windows registry or path env var,
// consider them as global type instead of unknown. Such types can only be known after
Expand Down