Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log when default formatter is not ms-python.black-formatter #329

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Log when default formatter is not ms-python.black-formatter #329

merged 3 commits into from
Oct 2, 2023

Conversation

karthiknadig
Copy link
Member

@karthiknadig karthiknadig commented Sep 27, 2023 •
edited
Loading

Closes #328

@karthiknadig karthiknadig self-assigned this Sep 27, 2023
@karthiknadig karthiknadig added the bug Issue identified by VS Code Team member as probable bug label Sep 27, 2023
karthiknadig
karthiknadig commented Sep 27, 2023
View reviewed changes
src/common/settings.ts Outdated Show resolved Hide resolved
@karthiknadig karthiknadig marked this pull request as ready for review October 2, 2023 20:01
@karthiknadig karthiknadig merged commit 4a193df into microsoft:main Oct 2, 2023
16 checks passed
@karthiknadig karthiknadig deleted the log1 branch October 2, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luabud luabud luabud left review comments

@eleanorjboyd eleanorjboyd eleanorjboyd approved these changes

@anthonykim1 anthonykim1 Awaiting requested review from anthonykim1

Assignees

@karthiknadig karthiknadig

Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add logs that tell users what is the current default formatter
3 participants
@karthiknadig @eleanorjboyd @luabud