Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Makes version extraction more robust #306

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Makes version extraction more robust #306

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
628de3a
make version extraction more robust
Sep 5, 2023
15f993d
udpated regex
Sep 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion bundled/tool/lsp_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
import json
import os
import pathlib
import re
import sys
import traceback
from typing import Any, Dict, List, Optional, Sequence, Union
Expand Down Expand Up @@ -238,7 +239,7 @@ def _log_version_info() -> None:
# This is text we get from running `black --version`
# black, 22.3.0 (compiled: yes) <--- This is the version we want.
first_line = result.stdout.splitlines(keepends=False)[0]
parts = [v for v in first_line.split(" ") if "." in v]
parts = [v for v in first_line.split(" ") if re.match("\d+\.\d+\S*", v)]
if len(parts) == 1:
actual_version = parts[0]
else:
Expand Down