Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[thrift] Update thrift 0.20.0 git reference #39787

Merged
merged 2 commits into from
Jul 10, 2024
Merged

[thrift] Update thrift 0.20.0 git reference #39787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2975373
[thrift] Use v0.20.0 tag
harris-josh Jul 9, 2024
850ada0
[thrift] Update thrift to version 0.20.0#1
harris-josh Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ports/thrift/portfile.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ vcpkg_find_acquire_program(BISON)
vcpkg_from_github(
OUT_SOURCE_PATH SOURCE_PATH
REPO apache/thrift
REF "${VERSION}"
REF "v${VERSION}"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like the Thrift repository is using a convention where the latest releases are all tagged vX.Y.Z, so I think this minor change should work.

I suppose this could change in the future, but I think this is probably the cleanest solution for now.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thrift repository is using a convention where the latest releases are all tagged vX.Y.Z

I can confirm that. I would also recommend to reference the release tag as it never changes after the release. Sorry for any confusion, was not aware that a single commit may cause such a tail of problems.

SHA512 5e4ee9870b30fe5ba484d39781c435716f7f3903793dc8aae96594ca813b1a5a73363b84719038ca8fa3ab8ef0a419a28410d936ff7b3bbadf36fc085a6883ae
HEAD_REF master
PATCHES
Expand Down
1 change: 1 addition & 0 deletions ports/thrift/vcpkg.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "thrift",
"version": "0.20.0",
"port-version": 1,
"description": "Apache Thrift is a software project spanning a variety of programming languages and use cases. Our goal is to make reliable, performant communication and data serialization across languages as efficient and seamless as possible.",
"homepage": "https://github.com/apache/thrift",
"license": "Apache-2.0",
Expand Down
2 changes: 1 addition & 1 deletion versions/baseline.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8730,7 +8730,7 @@
},
"thrift": {
"baseline": "0.20.0",
"port-version": 0
"port-version": 1
},
"tidy-html5": {
"baseline": "5.8.0",
Expand Down
5 changes: 5 additions & 0 deletions versions/t-/thrift.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,10 @@
{
"versions": [
{
"git-tree": "13757a6b05741cf3c9c39e3a1dcc5e5cd685e025",
"version": "0.20.0",
"port-version": 1
},
{
"git-tree": "6855be1ce96497811d4eb0a9879baf6cf1b3610c",
"version": "0.20.0",
Expand Down