Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[seacas/vtkm/vtk/paraview] Add/update ports. #27928

Merged
merged 137 commits into from
Jan 20, 2023
Merged
Show file tree
Hide file tree
Changes from 136 commits
Commits
Show all changes
137 commits
Select commit Hold shift + click to select a range
d1c02e0
[cgns] update to 4.2.0
Neumann-A Jun 2, 2021
4004fb2
[vtk-m] update to 1.6.0
Neumann-A Jun 2, 2021
af408bf
[vtk] Update to 9.0.1-pv5.9.1
Neumann-A Jun 2, 2021
f9ed7b3
[ParaView] Update to 5.9.1
Neumann-A Jun 2, 2021
79f259d
version stuff
Neumann-A Jun 2, 2021
ede762b
fix automatic svg linkage in static builds
Neumann-A Jun 7, 2021
df79d40
update qt5-svg
Neumann-A Jun 7, 2021
321cfcd
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Jun 11, 2021
53313c1
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Jun 22, 2021
7661abc
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Jul 26, 2021
da47cb9
revisit vtk
Neumann-A Jul 31, 2021
b229b60
bump version
Neumann-A Jul 31, 2021
5381f53
remove two commented lines
Neumann-A Jul 31, 2021
6321a69
version stuff
Neumann-A Jul 31, 2021
a3e6756
remove old PR version
Neumann-A Aug 2, 2021
dcb7db8
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Nov 17, 2022
77bf709
commit stuff
Neumann-A Nov 19, 2022
7a3be86
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Nov 19, 2022
36afd75
commit stuff
Neumann-A Nov 19, 2022
64f319a
update notes
Neumann-A Nov 19, 2022
4dcec09
wip commit
Neumann-A Nov 20, 2022
fcf30a0
update paraview
Neumann-A Nov 20, 2022
4ce02dc
fix hdf5 patch
Neumann-A Nov 20, 2022
fce11b0
fix patch
Neumann-A Nov 20, 2022
394b936
fix patch
Neumann-A Nov 20, 2022
0336b5b
fix portfile
Neumann-A Nov 20, 2022
e3f2bc0
add mpi feature
Neumann-A Nov 20, 2022
f9a3e4c
format manifest
Neumann-A Nov 20, 2022
295be01
use relativ path
Neumann-A Nov 20, 2022
1d7e3f6
trace
Neumann-A Nov 20, 2022
4a89034
retry
Neumann-A Nov 20, 2022
d1d8a9d
move qml files again
Neumann-A Nov 20, 2022
2753824
try with host triplet
Neumann-A Nov 20, 2022
29f48a9
- use VCPKG_CRT_LINKAGE
Neumann-A Nov 20, 2022
32bab80
fix casing Zlib
Neumann-A Nov 20, 2022
47efcca
hopefully more fixes on other platforms.
Neumann-A Nov 21, 2022
5efded1
fix patch
Neumann-A Nov 21, 2022
68304d6
fix missing ws
Neumann-A Nov 21, 2022
03a7b70
fix typos
Neumann-A Nov 21, 2022
dd747a7
scale down to warning
Neumann-A Nov 21, 2022
20754fc
revert jsoncpp change
Neumann-A Nov 22, 2022
1fa18a0
move trace option to failing port
Neumann-A Nov 22, 2022
616633c
move trace option to failing port
Neumann-A Nov 22, 2022
3243625
Revert "trilinos vcpkg.json changes"
Neumann-A Nov 22, 2022
3eaa295
Merge branch 'update-paraview' of https://github.com/Neumann-A/vcpkg …
Neumann-A Nov 22, 2022
ee75026
verdict fix osx build ?
Neumann-A Nov 22, 2022
b31e618
fix patch
Neumann-A Nov 22, 2022
03261c2
fix internal find_package call
Neumann-A Nov 22, 2022
cdb4a41
also apply correct case for metis
Neumann-A Nov 22, 2022
9ca26b1
disable METIS on osx
Neumann-A Nov 22, 2022
0f5a5bb
vtk-m don't support arm.
Neumann-A Nov 22, 2022
ff8f68c
force more features in Ci
Neumann-A Nov 22, 2022
43ecb6f
fix missing ,
Neumann-A Nov 22, 2022
3bfad26
more fixes
Neumann-A Nov 22, 2022
f862d05
more vtk python try and error.
Neumann-A Nov 22, 2022
6dce336
- paraview python setup same as vtk
Neumann-A Nov 22, 2022
1f7257d
fix case and remove fmt for openimageio.
Neumann-A Nov 22, 2022
c6ba7d5
trying to fix stuff
Neumann-A Nov 22, 2022
c2263b3
set hash to 0
Neumann-A Nov 22, 2022
0c46a58
[skip actions] add missing module
Neumann-A Nov 22, 2022
f45297b
WebCore module moved to paraview&python
Neumann-A Nov 22, 2022
ac59df2
fixes
Neumann-A Nov 22, 2022
4ecbe66
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Nov 22, 2022
b5d63c2
remove patch in vtk-dicom
Neumann-A Nov 22, 2022
05c0276
add var to maybe unused
Neumann-A Nov 22, 2022
d3f9c39
use correct 5.11 ref instead of the one in release
Neumann-A Nov 22, 2022
fb21f73
Patch cleanup round 1
Neumann-A Nov 22, 2022
ee9751c
remove empty patch parts
Neumann-A Nov 23, 2022
ac1feb9
fix vtkm configs
Neumann-A Nov 23, 2022
b661738
reintegrate jsoncpp.patch
Neumann-A Nov 23, 2022
87ec397
fix patch
Neumann-A Nov 23, 2022
b291987
add single seacas/kokkos/zoltan ports
Neumann-A Nov 23, 2022
dd28008
throw out trilinos, zoltan, kokkos
Neumann-A Nov 24, 2022
248dd74
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Nov 24, 2022
342b3d3
fix mpi feature
Neumann-A Nov 24, 2022
e0e8e04
fix dependency
Neumann-A Nov 24, 2022
f8458eb
retry dep fix
Neumann-A Nov 24, 2022
05e3e83
rename target
Neumann-A Nov 24, 2022
333bb3d
remove double line
Neumann-A Nov 24, 2022
d3a677f
fix target
Neumann-A Nov 24, 2022
4eff4f9
fix patch
Neumann-A Nov 24, 2022
55b13cf
retry
Neumann-A Nov 24, 2022
2ff3de1
remove cgns config
Neumann-A Nov 24, 2022
2c7f071
fix cgns
Neumann-A Nov 24, 2022
cdf5fbf
no seacas trace
Neumann-A Nov 24, 2022
fa21694
lowercase hdf5 target
Neumann-A Nov 24, 2022
ea76af0
fix case of metis
Neumann-A Nov 24, 2022
12f09bf
disable Fortran
Neumann-A Nov 24, 2022
3139d68
add iotr patch
Neumann-A Nov 24, 2022
e8d0892
add additional config folder
Neumann-A Nov 24, 2022
f7cfd71
handel case sensitive Seacas again
Neumann-A Nov 24, 2022
e08b837
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Nov 25, 2022
bf2b174
get trace again and force jsoncpp
Neumann-A Nov 25, 2022
665600d
update cmake to 3.25.0
Neumann-A Nov 25, 2022
196116e
bump port-version
Neumann-A Nov 25, 2022
10f1fbb
Merge branch 'microsoft:master' into update_cmake_3.25
Neumann-A Nov 28, 2022
b55746c
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Nov 29, 2022
acefa21
Merge remote-tracking branch 'origin/update_cmake_3.25' into update-p…
Neumann-A Nov 29, 2022
d6e77b8
add patch from vtk upstream
Neumann-A Nov 29, 2022
bf911c5
Merge branch 'update-paraview' of https://github.com/Neumann-A/vcpkg …
Neumann-A Nov 29, 2022
987a83b
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Nov 29, 2022
c15fec2
cleanup, format-manifest
Neumann-A Nov 29, 2022
90e6671
fix port version
Neumann-A Nov 29, 2022
e67d38a
v db
Neumann-A Nov 29, 2022
fc69380
opencv4 always inject deps.
Neumann-A Nov 30, 2022
0bb8a44
fix test port to not require stuff which is not supported on x86
Neumann-A Nov 30, 2022
68f970d
Fix HDF5 lookup in opencv4
Neumann-A Nov 30, 2022
ab38852
only delete bin folder in static builds
Neumann-A Nov 30, 2022
68be45e
add license field
Neumann-A Nov 30, 2022
c7d5b1a
v db
Neumann-A Nov 30, 2022
ec671ac
add missing "
Neumann-A Nov 30, 2022
4e6f3b5
v db
Neumann-A Nov 30, 2022
9aaf430
trace again
Neumann-A Nov 30, 2022
cbb58fd
fix rtabmap python dep
Neumann-A Nov 30, 2022
0d052ce
fix openimageio by deleting the find module
Neumann-A Nov 30, 2022
845ae71
v db
Neumann-A Nov 30, 2022
78e52c6
cr cleanup
Neumann-A Dec 1, 2022
7a3499b
v db
Neumann-A Dec 1, 2022
767df69
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Dec 9, 2022
27a75b6
opencv4 v db due to merge with master. Had to bump port version
Neumann-A Dec 9, 2022
b2b91b4
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Dec 16, 2022
8d8a2af
v db
Neumann-A Dec 16, 2022
b25f62c
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Dec 20, 2022
ee972f1
v db
Neumann-A Dec 20, 2022
748865e
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Jan 7, 2023
a905b6c
v db
Neumann-A Jan 7, 2023
a4e4a47
CR comments
Neumann-A Jan 8, 2023
b4c7169
v db for cr comments
Neumann-A Jan 8, 2023
a10d3e6
trace theia output
Neumann-A Jan 8, 2023
490c58f
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Jan 16, 2023
e9b259a
revert theia trace
Neumann-A Jan 16, 2023
5b1e3b1
v db
Neumann-A Jan 16, 2023
45d024e
try without patch
Neumann-A Jan 17, 2023
40d24c8
revert rtabmap changes
Neumann-A Jan 17, 2023
c7564b5
Merge remote-tracking branch 'upstream/master' into update-paraview
Neumann-A Jan 18, 2023
2c9e071
v db after merge
Neumann-A Jan 18, 2023
8f70dff
v db for all
Neumann-A Jan 18, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions ports/cgns/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ vcpkg_cmake_configure(
OPTIONS
${FEATURE_OPTIONS}
${CGNS_BUILD_OPTS}
-DCGNS_ENABLE_SCOPING:BOOL=ON
)

vcpkg_cmake_install()
Expand Down Expand Up @@ -79,5 +80,9 @@ endif()
file(REMOVE "${CURRENT_PACKAGES_DIR}/include/cgnsBuild.defs" "${CURRENT_PACKAGES_DIR}/include/cgnsconfig.h")
file(INSTALL "${CURRENT_PORT_DIR}/cgnsconfig.h" DESTINATION "${CURRENT_PACKAGES_DIR}/include") # the include is all that is needed

if(VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic")
vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/include/cgnslib.h" "defined(USE_DLL)" "1")
endif()

# Handle copyright
configure_file("${SOURCE_PATH}/license.txt" "${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright" COPYONLY)
2 changes: 1 addition & 1 deletion ports/cgns/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "cgns",
"version-semver": "4.3.0",
"port-version": 2,
"port-version": 3,
"description": "The CFD General Notation System (CGNS) provides a standard for recording and recovering computer data associated with the numerical solution of fluid dynamics equations.",
"homepage": "http://cgns.org/",
"license": "Zlib",
Expand Down
6 changes: 3 additions & 3 deletions ports/hdf5/hdf5_config.patch
Original file line number Diff line number Diff line change
Expand Up @@ -13,10 +13,10 @@ index 4d02c9c..8c10d2d 100644
set (${HDF5_PACKAGE_NAME}_MPI_C_INCLUDE_PATH "@MPI_C_INCLUDE_DIRS@")
set (${HDF5_PACKAGE_NAME}_MPI_C_LIBRARIES "@MPI_C_LIBRARIES@")
if (${HDF5_PACKAGE_NAME}_BUILD_FORTRAN)
@@ -111,11 +114,11 @@ set (${HDF5_PACKAGE_NAME}_VERSION_MINOR @HDF5_VERSION_MINOR@)
@@ -111,11 +114,9 @@ set (${HDF5_PACKAGE_NAME}_VERSION_MINOR @HDF5_VERSION_MINOR@)
# project which has already built hdf5 as a subproject
#-----------------------------------------------------------------------------
if (NOT TARGET "@HDF5_PACKAGE@")
-if (NOT TARGET "@HDF5_PACKAGE@")
- if (${HDF5_PACKAGE_NAME}_ENABLE_Z_LIB_SUPPORT AND ${HDF5_PACKAGE_NAME}_PACKAGE_EXTLIBS)
- include (@PACKAGE_SHARE_INSTALL_DIR@/@ZLIB_PACKAGE_NAME@@HDF_PACKAGE_EXT@-targets.cmake)
+ if (${HDF5_PACKAGE_NAME}_ENABLE_Z_LIB_SUPPORT)
Expand All @@ -26,6 +26,6 @@ index 4d02c9c..8c10d2d 100644
- include (@PACKAGE_SHARE_INSTALL_DIR@/@SZIP_PACKAGE_NAME@@HDF_PACKAGE_EXT@-targets.cmake)
+ if (${HDF5_PACKAGE_NAME}_ENABLE_SZIP_SUPPORT)
+ find_dependency(szip)
endif ()
- endif ()
include (@PACKAGE_SHARE_INSTALL_DIR@/@HDF5_PACKAGE@@HDF_PACKAGE_EXT@-targets.cmake)
endif ()
4 changes: 4 additions & 0 deletions ports/hdf5/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -157,3 +157,7 @@ file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/debug/include")
configure_file("${CMAKE_CURRENT_LIST_DIR}/vcpkg-cmake-wrapper.cmake" "${CURRENT_PACKAGES_DIR}/share/${PORT}/vcpkg-cmake-wrapper.cmake" @ONLY)

file(RENAME "${CURRENT_PACKAGES_DIR}/share/${PORT}/data/COPYING" "${CURRENT_PACKAGES_DIR}/share/${PORT}/copyright")

if(VCPKG_LIBRARY_LINKAGE STREQUAL "dynamic")
vcpkg_replace_string("${CURRENT_PACKAGES_DIR}/include/H5public.h" "#define H5public_H" "#define H5public_H\n#ifndef H5_BUILT_AS_DYNAMIC_LIB\n#define H5_BUILT_AS_DYNAMIC_LIB\n#endif\n")
endif()
1 change: 0 additions & 1 deletion ports/hdf5/vcpkg-cmake-wrapper.cmake
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

if(CMAKE_VERSION VERSION_GREATER_EQUAL 3.3)
cmake_policy(PUSH)
cmake_policy(SET CMP0057 NEW)
Expand Down
2 changes: 1 addition & 1 deletion ports/hdf5/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "hdf5",
"version": "1.12.2",
"port-version": 4,
"port-version": 5,
"description": "HDF5 is a data model, library, and file format for storing and managing data",
"homepage": "https://www.hdfgroup.org/downloads/hdf5/",
"license": "BSD-3-Clause",
Expand Down
8 changes: 6 additions & 2 deletions ports/matio/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "matio",
"version-semver": "1.5.23",
"version": "1.5.23",
"port-version": 1,
"description": "MATLAB MAT File I/O Library",
"homepage": "https://github.com/tbeu/matio",
"license": "BSD-2-Clause",
Expand All @@ -21,7 +22,10 @@
"hdf5": {
"description": "Check for HDF5 library",
"dependencies": [
"hdf5"
{
"name": "hdf5",
"default-features": false
}
]
},
"mat73": {
Expand Down
7 changes: 3 additions & 4 deletions ports/opencv4/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ endif()
# Build image quality module when building with 'contrib' feature and not UWP.
set(BUILD_opencv_quality OFF)
if("contrib" IN_LIST FEATURES)
if (VCPKG_TARGET_IS_UWP OR VCPKG_TARGET_IS_IOS)
if (VCPKG_TARGET_IS_UWP OR VCPKG_TARGET_IS_IOS OR (VCPKG_TARGET_ARCHITECTURE MATCHES "arm" AND VCPKG_TARGET_IS_WINDOWS))
set(BUILD_opencv_quality OFF)
message(WARNING "The image quality module (quality) does not build for UWP or iOS, the module has been disabled.")
# The hdf module is silently disabled by OpenCVs buildsystem if HDF5 is not detected.
Expand Down Expand Up @@ -458,7 +458,6 @@ if (NOT VCPKG_BUILD_TYPE)
)
endif()

if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
file(READ "${CURRENT_PACKAGES_DIR}/share/opencv4/OpenCVModules.cmake" OPENCV_MODULES)
set(DEPS_STRING "include(CMakeFindDependencyMacro)
if(${BUILD_opencv_dnn})
Expand All @@ -484,7 +483,7 @@ find_dependency(Threads)")
if("cuda" IN_LIST FEATURES)
string(APPEND DEPS_STRING "\nfind_dependency(CUDA)")
endif()
if(BUILD_opencv_quality)
if(BUILD_opencv_quality AND "contrib" IN_LIST FEATURES)
string(APPEND DEPS_STRING "
# C language is required for try_compile tests in FindHDF5
enable_language(C)
Expand Down Expand Up @@ -556,7 +555,7 @@ find_dependency(Qt${USE_QT_VERSION} COMPONENTS OpenGL)")

file(WRITE "${CURRENT_PACKAGES_DIR}/share/opencv4/OpenCVModules.cmake" "${OPENCV_MODULES}")


if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin")
endif()

Expand Down
1 change: 1 addition & 0 deletions ports/opencv4/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"name": "opencv4",
"version": "4.7.0",
"port-version": 1,
"description": "computer vision library",
"homepage": "https://github.com/opencv/opencv",
"license": "Apache-2.0",
Expand Down
3 changes: 3 additions & 0 deletions ports/openimageio/portfile.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,8 @@ file(REMOVE
"${SOURCE_PATH}/src/cmake/modules/FindOpenCV.cmake"
"${SOURCE_PATH}/src/cmake/modules/FindOpenJPEG.cmake"
"${SOURCE_PATH}/src/cmake/modules/FindWebP.cmake"
"${SOURCE_PATH}/src/cmake/modules/Findfmt.cmake"
"${SOURCE_PATH}/src/cmake/modules/FindTBB.cmake"
)

vcpkg_check_features(OUT_FEATURE_OPTIONS FEATURE_OPTIONS
Expand Down Expand Up @@ -64,6 +66,7 @@ vcpkg_cmake_configure(
-DBUILD_DOCS=OFF
-DINSTALL_DOCS=OFF
-DENABLE_INSTALL_testtex=OFF
"-DFMT_INCLUDES=${CURRENT_INSTALLED_DIR}/include"
"-DREQUIRED_DEPS=fmt;JPEG;Libheif;Libsquish;PNG;Robinmap"
MAYBE_UNUSED_VARIABLES
ENABLE_INSTALL_testtex
Expand Down
2 changes: 1 addition & 1 deletion ports/openimageio/vcpkg.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "openimageio",
"version": "2.4.5.0",
"port-version": 1,
"port-version": 2,
"description": "A library for reading and writing images, and a bunch of related classes, utilities, and application.",
"homepage": "https://github.com/OpenImageIO/oiio",
"license": "BSD-3-Clause",
Expand Down
24 changes: 0 additions & 24 deletions ports/paraview/catalyst_install.patch

This file was deleted.

29 changes: 0 additions & 29 deletions ports/paraview/cgns.patch

This file was deleted.

64 changes: 31 additions & 33 deletions ports/paraview/external_vtk.patch
Original file line number Diff line number Diff line change
@@ -1,20 +1,8 @@
diff --git a/CMake/ParaViewClient.cmake b/CMake/ParaViewClient.cmake
index b0dea2b32..b035a9dc3 100644
--- a/CMake/ParaViewClient.cmake
+++ b/CMake/ParaViewClient.cmake
@@ -516,6 +516,7 @@ function (paraview_client_documentation)
NAMES xmlpatterns-qt5 xmlpatterns
HINTS "${Qt5_DIR}/../../../bin"
"${Qt5_DIR}/../../../libexec/qt5/bin"
+ "${Qt5_DIR}/../../../tools/qt5/bin"
DOC "Path to xmlpatterns")
mark_as_advanced(qt_xmlpatterns_executable)

diff --git a/CMake/ParaViewOptions.cmake b/CMake/ParaViewOptions.cmake
index f544a7c06..c51278931 100644
index 70c771151..14df81490 100644
--- a/CMake/ParaViewOptions.cmake
+++ b/CMake/ParaViewOptions.cmake
@@ -88,7 +88,7 @@ endif()
@@ -99,7 +99,7 @@ endif()
#========================================================================

# XXX(VTK): External VTK is not yet actually supported.
Expand All @@ -24,58 +12,68 @@ index f544a7c06..c51278931 100644
mark_as_advanced(PARAVIEW_USE_EXTERNAL_VTK)
else ()
diff --git a/CMakeLists.txt b/CMakeLists.txt
index 1af77d164..bebcb83ee 100644
index 6ee167322..628745584 100644
--- a/CMakeLists.txt
+++ b/CMakeLists.txt
@@ -72,7 +72,8 @@ if (NOT CMAKE_INSTALL_LICENSEDIR)
@@ -73,7 +73,13 @@ if (NOT CMAKE_INSTALL_LICENSEDIR)
endif ()

set(paraview_cmake_dir "${CMAKE_CURRENT_SOURCE_DIR}/CMake")
-set(vtk_cmake_dir "${CMAKE_CURRENT_SOURCE_DIR}/VTK/CMake")
+set(vtk_cmake_dir "${_VCPKG_INSTALLED_DIR}/${VCPKG_TARGET_TRIPLET}/share/vtk")
+message(STATUS "vtk_cmake_dir:${vtk_cmake_dir}")
+if (PARAVIEW_USE_EXTERNAL_VTK)
+ find_package(VTK CONFIG REQUIRED)
+ get_filename_component(vtk_cmake_dir "${VTK_CONFIG}" DIRECTORY )
+else()
+ set(vtk_cmake_dir "${CMAKE_CURRENT_SOURCE_DIR}/VTK/CMake")
+endif()
+
if (NOT IS_DIRECTORY "${vtk_cmake_dir}")
message(FATAL_ERROR
"Failed to find the VTK CMake directory. Did you forget to initialize the "
@@ -383,9 +384,73 @@ endif ()
@@ -242,9 +246,7 @@ if (PARAVIEW_USE_FORTRAN)
enable_language(Fortran OPTIONAL)
endif ()

-if (PARAVIEW_USE_EXTERNAL_VTK)
- find_package(VTK REQUIRED)
-else ()
+if (NOT PARAVIEW_USE_EXTERNAL_VTK)
list(APPEND CMAKE_MODULE_PATH
"${CMAKE_CURRENT_SOURCE_DIR}/VTK/CMake")
include(vtkCMakeBackports)
@@ -423,9 +425,67 @@ endif ()

if (PARAVIEW_USE_EXTERNAL_VTK)
if (paraview_required_modules OR paraview_unrecognized_modules)
- message(FATAL_ERROR
- "The following modules were requested or required, but not found: "
- "${paraview_required_modules};${paraview_unrecognized_modules}.")
+ message(STATUS "REQUIRED:${paraview_required_modules}")
+ foreach(mod ${paraview_required_modules})
+ if(NOT TARGET ${mod})
+ message(STATUS "REQUIRED TARGET not defined: ${mod}")
+ list(APPEND modules_notarget ${mod})
+ endif()
+ if(${mod} MATCHES "VTK::") # For better debugging
+ message(STATUS "VTK TARGET found: ${mod}")
+ list(APPEND vtk_modules ${mod})
+ endif()
+ endforeach()
+ foreach(mod ${paraview_unrecognized_modules})
+ if(NOT TARGET ${mod})
+ message(STATUS "UNREC TARGET not defined: ${mod}")
+ list(FIND paraview_rejected_modules ${mod} _found_mod)
+ if(_found_mod GREATER_EQUAL 0)
+ message(STATUS "MODULE ${mod} not necessary; Removing from unrecognized")
+ list(APPEND _to_remove ${mod})
+ endif()
+ else()
+ list(APPEND _to_remove ${mod})
+ #list(APPEND vtk_modules ${mod}) #probably do not need to add unrecognized_modules to the wrapper
+ endif()
+ endforeach()
+ message(STATUS "UNRECOGNIZED:${paraview_unrecognized_modules}")
+ list(REMOVE_ITEM paraview_unrecognized_modules ${_to_remove})
+ message(STATUS "UNRECOGNIZED:${paraview_unrecognized_modules}")
+ message(STATUS "REJECTED MODULES: ${paraview_rejected_modules}")
+ message(STATUS "UNRECOGNIZED WITHOUT REJECTED AND KNOWN TARGETS: ${paraview_unrecognized_modules}")
+ message(STATUS "ALL PROVIDED MODULES: ${paraview_modules}")
+ set(_unnecessary_moduls ${paraview_modules})
+ list(REMOVE_ITEM _unnecessary_moduls ${paraview_required_modules})
+ message(STATUS "Unnecessary MODULES: ${_unnecessary_moduls}")
+ if(modules_notarget)
+ message(FATAL_ERROR
+ "The following modules were requested or required, but not found: "
Expand Down Expand Up @@ -114,7 +112,7 @@ index 1af77d164..bebcb83ee 100644
endif ()

if (PARAVIEW_USE_PYTHON)
@@ -459,7 +524,7 @@ else ()
@@ -508,7 +574,7 @@ else ()
endif()

# Set up these variables now so that modules may acess them
Expand All @@ -123,7 +121,7 @@ index 1af77d164..bebcb83ee 100644
set(vtk_cmake_dir
"${CMAKE_CURRENT_SOURCE_DIR}/VTK/CMake")
set(vtk_cmake_destination
@@ -558,6 +623,9 @@ set(_paraview_add_tests_default_data_directory
@@ -642,6 +708,9 @@ set(_paraview_add_tests_default_data_directory
set(_paraview_add_tests_default_test_data_target
"ParaViewData")

Expand All @@ -133,17 +131,17 @@ index 1af77d164..bebcb83ee 100644
vtk_module_build(
MODULES ${paraview_modules}
KITS ${paraview_kits}
@@ -596,9 +664,11 @@ vtk_module_build(
TEST_OUTPUT_DATA_DIRECTORY "${paraview_test_data_directory_output}")
@@ -703,9 +772,11 @@ if (PARAVIEW_ENABLE_CATALYST)
endif ()

include(vtkModuleJson)
-vtk_module_json(
- MODULES ${vtk_modules}
- OUTPUT "vtk-modules.json")
+if(NOT PARAVIEW_USE_EXTERNAL_VTK)
+ vtk_module_json(
+ MODULES ${vtk_modules}
+ OUTPUT "vtk-modules.json")
+ vtk_module_json(
+ MODULES ${vtk_modules}
+ OUTPUT "vtk-modules.json")
+endif()
vtk_module_json(
MODULES ${paraview_modules}
Expand Down
Loading