This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Expand prefer-array-literal rule #842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IllusionMH
suggested changes
Mar 12, 2019
There was a problem hiding this comment.
@drexler thank you for PR! Rule/test code good 👍
I'm in favor of lint error fix in scope of this PR, however workaround for lint error can be greatly simplified.
IllusionMH
added
the
PR: Waiting for Author
As long as the rule works the same, let's fix it up! +1 |
drexler
force-pushed
the
fix-prefer-array-literal
branch
from
499a430
to
328bb3b
Compare
|
Thanks for the review guys - PR update pushed. |
JoshuaKGoldberg
added
PR: Waiting for Reviewer
IllusionMH
approved these changes
Mar 12, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
Expands the
prefer-array-literalrule to cover Array functionsIs there anything you'd like reviewers to focus on?
After implementing this change,
react-a11y-titlestest was was flagged by the rule update and i made some changes to it as part of this PR. I am unsure if it's appropriate to include those changes here or it should be part of another issue to address the breaking change. @JoshuaKGoldberg, @IllusionMH thoughts?