This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Strict order of rules in README.md #817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IllusionMH
commented
Feb 9, 2019
IllusionMH
commented
Feb 9, 2019
|
This looks great, thanks @IllusionMH! Confirmed Releases.md's mention of |
JoshuaKGoldberg
approved these changes
Feb 10, 2019
apawast
pushed a commit
to lupine86/tslint-microsoft-contrib
that referenced
this pull request
Feb 26, 2019
* Validate order of rules in README.md (fixes microsoft#816) * Fix rules order in README.md * create-rule task also updates README (fixed microsoft#816) * Update CONTRIBUTING.md with detais about README.md actions (fixes microsoft#648)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
Overview of change:
New validation is added to
npm testthat will check if rules inREAME.md's table are sorted alphabetically.Updated
create-rulescript will also add row for new rule in correct place.@nextwill be used as placeholder for version as was discussed in #648.Is there anything you'd like reviewers to focus on?
I've used regular expression to work with table in
README.mdbecause HTML markup is pretty simple, RegExp is simple enough, and it helps to avoid adding another dependency for temporary solution (should be removed with #575).Also, looks like VS Code no longer sets environment variable in terminal, so files should be opened by hand.
Please check Releases that was updated to mention
@nextplaceholder.