Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Upgrade npm-run-all. Fixes compromised transitive dependency #657

Merged
merged 1 commit into from
Nov 27, 2018

Conversation

IllusionMH
Copy link
Contributor

@IllusionMH IllusionMH commented Nov 26, 2018

PR checklist

  • Addresses an existing issue: no issue created
  • New feature, bugfix, or enhancement
    • Includes tests
  • Documentation update

Overview of change:

This PR bumps npm-run-all that had compromised transitive dependency in version 4.1.3 to 4.1.5 that uses alternative package and do not contains compromised packages.

Please see:
https://www.npmjs.com/advisories/737
mysticatea/npm-run-all#150
dominictarr/event-stream#116

Is there anything you'd like reviewers to focus on?

This dependency is listed in devDependencies section and 6.0.0-beta installations may install compromised dependency, but should not be used if no other dependencies in project will require event-stream

I've remembered that removing devDependencies is part of build process
https://github.com/Microsoft/tslint-microsoft-contrib/blob/4b911106ba4efa13996f05ada4a2ec7450330bc1/package.json#L60
https://github.com/Microsoft/tslint-microsoft-contrib/blob/4b911106ba4efa13996f05ada4a2ec7450330bc1/build-tasks/generate-package-json-for-npm.js#L8

So only developers of this package are affected.

@IllusionMH
Copy link
Contributor Author

Updated description to clarify that only developers of this package were affected, and 6.0.0-beta doesn't contain compromised devDependencies.

List of contributors that published commits after compromised package was added to dependencies:
@JoshuaKGoldberg @IllusionMH @noamyogev84 @mesaugat @Retsam @esuau @reduckted @jcnsilva @Dgaduin @Igorbek

Please be informed about issue with event-stream/flatmap-stream

@IllusionMH IllusionMH changed the title Upgrade npm-run-all. Fixes compromised transitive dependencies Upgrade npm-run-all. Fixes compromised transitive dependency Nov 27, 2018
@JoshuaKGoldberg JoshuaKGoldberg merged commit a58f3d5 into microsoft:master Nov 27, 2018
@JoshuaKGoldberg
Copy link

Thanks @IllusionMH!

...and now GitHub is showing a warning on the repo:

image

Verified the checksums match in package-lock.json.

@IllusionMH IllusionMH deleted the upgrade-npm-run-all branch December 3, 2018 12:28
@IllusionMH IllusionMH added this to the 6.0.0 milestone Feb 3, 2019
apawast pushed a commit to lupine86/tslint-microsoft-contrib that referenced this pull request Feb 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants