This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
Fix #571: Avoid redundant rel values in react-anchor-blank-noopener #574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hi @esuau, thanks for sending this! Per discussion in the linked issue, it's unclear which browsers support the better behavior of inferring proper tags. We'll want to have a rule option to toggle this behavior. I'll leave this PR open for a bit in case you have time to add that option in. If not, no worries! |
|
Sure, I'll try to work on this. |
added 5 commits
October 24, 2018 00:44
…/esuau/tslint-microsoft-contrib into rule/react-anchor-blank-noopener
JoshuaKGoldberg
suggested changes
Oct 24, 2018
|
Hello. Merge was clean actually. I just did a rebase on your master branch. 😊 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Fixes #571
The rule
react-anchor-blank-noopenerwas designed to avoid security vulnerabilities by the use ofrel="noopener noreferrer"in anchor tags containingtarget="_blank". It appears thatrel="noreferrer"impliesrel="noopener".Solution
I removed the obligation to use both
noopenerandnoreferrerwhentarget="_blank"is used, and only kept the rule to addrel="noreferrer".