Skip to content
This repository has been archived by the owner on Jul 15, 2023. It is now read-only.

Fix #275 Add new rule for accessible input elements #547

Merged

Conversation

br1anchen
Copy link
Contributor

fixes #275

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code mostly looks good - just the one performance improvement and undoing tslint.json changes!

src/reactA11yInputElementsRule.ts Show resolved Hide resolved
tslint.json Outdated
@@ -3,7 +3,10 @@
"dist/src"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like your auto-formatter got to tslint.json 😉 please revert these changes.

Copy link

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super, thanks @br1anchen!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 894dc6b into microsoft:master Oct 18, 2018
@JoshuaKGoldberg JoshuaKGoldberg added this to the 6.0.0 milestone Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

new a11y rule: accessible input elements
2 participants