#389 it.only/it.skip no longer triggers mocha-no-side-effect-code

closes #389
microsoft · Apr 17, 2018 · 696fb9d · 696fb9d · astorije · May 24, 2018
1 parent 2efd796
commit 696fb9d
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 1 deletion.
diff --git a/src/tests/MochaNoSideEffectCodeRuleTests.ts b/src/tests/MochaNoSideEffectCodeRuleTests.ts
@@ -62,6 +62,30 @@ describe('mochaNoSideEffectCodeRule', () : void => {
         TestHelper.assertViolations(ruleName, script, [ ]);
     });
 
+    it('should pass on usage of skip/only', () : void => {
+        const script : string = `
+            describe('someTest', (): void => {
+
+                it.skip((): void => {
+                });
+
+                describe.skip((): void => {
+                    it.skip((): void => {
+                    });
+                });
+
+                it.only((): void => {
+                });
+                describe.only((): void => {
+                    it.only((): void => {
+                    });
+                });
+            });
+        `;
+
+        TestHelper.assertViolations(ruleName, script, [ ]);
+    });
+
     it('should pass on function declarations', () : void => {
         const script : string = `
             describe('someTest', (): void => {

diff --git a/src/utils/MochaUtils.ts b/src/utils/MochaUtils.ts
@@ -41,8 +41,10 @@ export module MochaUtils {
      */
     export function isLifecycleMethod(call: ts.CallExpression): boolean {
         const functionName: string = AstUtils.getFunctionName(call);
+        const callText: string = call.expression.getText();
         return functionName === 'it' || functionName === 'specify'
             || functionName === 'before' || functionName === 'beforeEach' || functionName === 'beforeAll'
-            || functionName === 'after' || functionName === 'afterEach' || functionName === 'afterAll';
+            || functionName === 'after' || functionName === 'afterEach' || functionName === 'afterAll'
+            || callText === 'it.skip' || callText === 'it.only';
     }
 }