Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azuredevops_branch_policy_min_reviewers - Fix on_push_reset_approved_votes cannot set to true #792

Merged
merged 1 commit into from
Jun 15, 2023

Conversation

xuzhang3
Copy link
Collaborator

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number: #783
Fix on_push_reset_approved_votes cannot set to true when on_push_reset_all_votes is true

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

2. update test case
3. update document
@xuzhang3 xuzhang3 added this to the v0.6.0 milestone Jun 13, 2023
@xuzhang3
Copy link
Collaborator Author

=== RUN   TestAccBranchPolicyMinReviewers_basic
=== PAUSE TestAccBranchPolicyMinReviewers_basic
=== RUN   TestAccBranchPolicyMinReviewers_update
=== PAUSE TestAccBranchPolicyMinReviewers_requiresImportError
=== CONT  TestAccBranchPolicyMinReviewers_basic
=== CONT  TestAccBranchPolicyMinReviewers_resetAllVote
=== CONT  TestAccBranchPolicyMinReviewers_update
=== CONT  TestAccBranchPolicyMinReviewers_requiresImportError
--- PASS: TestAccBranchPolicyMinReviewers_basic (51.75s)
--- PASS: TestAccBranchPolicyMinReviewers_resetAllVote (51.95s)
--- PASS: TestAccBranchPolicyMinReviewers_requiresImportError (54.10s)
--- PASS: TestAccBranchPolicyMinReviewers_update (62.03s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        63.499s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant