Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade legacy API from v5 to v7 - azuredevops_check_approval, azuredevops_check_branch_control, azuredevops_check_business_hours, azuredevops_variable_group, azuredevops_variable_group(data source), azuredevops_group #785

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

xuzhang3
Copy link
Collaborator

@xuzhang3 xuzhang3 commented Jun 6, 2023

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number:
Update legacy API from v5 to v7 - Resources: azuredevops_check_approval, azuredevops_check_branch_control, azuredevops_check_business_hours, azuredevops_variable_group, azuredevops_variable_group(data source), azuredevops_group

Test log:

=== RUN   TestAccCheckApproval_basic
=== PAUSE TestAccCheckApproval_basic
=== RUN   TestAccCheckApproval_complete
=== PAUSE TestAccCheckApproval_complete
=== RUN   TestAccCheckApproval_update
=== PAUSE TestAccCheckApproval_update
=== CONT  TestAccCheckApproval_basic
=== CONT  TestAccCheckApproval_update
=== CONT  TestAccCheckApproval_complete
--- PASS: TestAccCheckApproval_complete (64.51s)
--- PASS: TestAccCheckApproval_basic (74.47s)
--- PASS: TestAccCheckApproval_update (103.29s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        108.503s

=== RUN   TestAccCheckBranchControl_basic
=== PAUSE TestAccCheckBranchControl_basic
=== RUN   TestAccCheckBranchControl_complete
=== PAUSE TestAccCheckBranchControl_complete
=== RUN   TestAccCheckBranchControl_update
=== PAUSE TestAccCheckBranchControl_update
=== CONT  TestAccCheckBranchControl_basic
=== CONT  TestAccCheckBranchControl_update
=== CONT  TestAccCheckBranchControl_complete
--- PASS: TestAccCheckBranchControl_basic (50.75s)
--- PASS: TestAccCheckBranchControl_complete (60.17s)
--- PASS: TestAccCheckBranchControl_update (70.82s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        74.950s

=== RUN   TestAccCheckBusinessHours_basic
=== PAUSE TestAccCheckBusinessHours_basic
=== RUN   TestAccCheckBusinessHours_complete
=== PAUSE TestAccCheckBusinessHours_complete
=== RUN   TestAccCheckBusinessHours_update
=== PAUSE TestAccCheckBusinessHours_update
=== CONT  TestAccCheckBusinessHours_basic
=== CONT  TestAccCheckBusinessHours_update
=== CONT  TestAccCheckBusinessHours_complete
--- PASS: TestAccCheckBusinessHours_complete (50.54s)
--- PASS: TestAccCheckBusinessHours_update (59.82s)
--- PASS: TestAccCheckBusinessHours_basic (60.57s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        61.263s

=== RUN   TestAccVariableGroup_DataSource
=== PAUSE TestAccVariableGroup_DataSource
=== RUN   TestAccVariableGroup_DataSourceKeyVault
=== PAUSE TestAccVariableGroup_DataSourceKeyVault
=== RUN   TestAccVariableGroup_CreateAndUpdate
=== PAUSE TestAccVariableGroup_CreateAndUpdate
=== CONT  TestAccVariableGroup_DataSource
=== CONT  TestAccVariableGroup_CreateAndUpdate
=== CONT  TestAccVariableGroup_DataSourceKeyVault
--- PASS: TestAccVariableGroup_DataSource (61.38s)
--- PASS: TestAccVariableGroup_CreateAndUpdate (78.83s)
--- PASS: TestAccVariableGroup_DataSourceKeyVault (81.85s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        88.435s

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3 xuzhang3 merged commit fbb84c3 into microsoft:main Jun 7, 2023
@xuzhang3 xuzhang3 added this to the v0.6.0 milestone Jun 7, 2023
@xuzhang3 xuzhang3 changed the title Ppgrade legacy API from v5 to v7 - azuredevops_check_approval, azuredevops_check_branch_control, azuredevops_check_business_hours, azuredevops_variable_group, azuredevops_variable_group(data source), azuredevops_group Ipgrade legacy API from v5 to v7 - azuredevops_check_approval, azuredevops_check_branch_control, azuredevops_check_business_hours, azuredevops_variable_group, azuredevops_variable_group(data source), azuredevops_group Jun 21, 2023
@xuzhang3 xuzhang3 changed the title Ipgrade legacy API from v5 to v7 - azuredevops_check_approval, azuredevops_check_branch_control, azuredevops_check_business_hours, azuredevops_variable_group, azuredevops_variable_group(data source), azuredevops_group Upgrade legacy API from v5 to v7 - azuredevops_check_approval, azuredevops_check_branch_control, azuredevops_check_business_hours, azuredevops_variable_group, azuredevops_variable_group(data source), azuredevops_group Jun 21, 2023
@xuzhang3 xuzhang3 deleted the f/api_upgrade branch October 23, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant