Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid fetch only 100 teams #778

Merged
merged 7 commits into from
Aug 7, 2023
Merged

Avoid fetch only 100 teams #778

merged 7 commits into from
Aug 7, 2023

Conversation

ricardosequeira
Copy link
Contributor

@ricardosequeira ricardosequeira commented May 23, 2023

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number: #766

Does this introduce a change to go.mod, go.sum or vendor/?

  • [] Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

Closes #766

@ricardosequeira
Copy link
Contributor Author

@microsoft-github-policy-service agree

@xuzhang3
Copy link
Collaborator

@ricardosequeira Some ORGs may have hundreds or thousands of teams. Get all teams at the same time may took a long time and cause performance issue. Can you refactor the top to a custom value with default values like 100?

@ricardosequeira
Copy link
Contributor Author

@xuzhang3, can you review this PR again?

@xuzhang3
Copy link
Collaborator

xuzhang3 commented Aug 2, 2023

@ricardosequeira please add the top to the schema. Also you need update the document too.

@ricardosequeira
Copy link
Contributor Author

@ricardosequeira please add the top to the schema. Also you need update the document too.

@xuzhang3, done

azuredevops/internal/service/core/data_team.go Outdated Show resolved Hide resolved
azuredevops/internal/service/core/data_teams.go Outdated Show resolved Hide resolved
azuredevops/internal/service/core/data_team.go Outdated Show resolved Hide resolved
website/docs/d/data_team.html.markdown Outdated Show resolved Hide resolved
@xuzhang3 xuzhang3 added this to the v0.8.0 milestone Aug 7, 2023
@xuzhang3
Copy link
Collaborator

xuzhang3 commented Aug 7, 2023

@ricardosequeira LGTM 🚢

@xuzhang3 xuzhang3 merged commit f1028a8 into microsoft:main Aug 7, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: Unable to find Team with name [<Team Name>] in project with ID [<Project ID>]
2 participants