Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Resource: azuredevops_identity_groups azuredevops_identity_group azuredevops_identity_user - Add timeout and update test case #1108

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

xuzhang3
Copy link
Collaborator

All Submissions:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My code follows the code style of this project.
  • I ran lint checks locally prior to submission.
  • Have you checked to ensure there aren't other open PRs for the same update/change?

What about the current behavior has changed?

Issue Number:

Data Resource:
azuredevops_identity_groups
azuredevops_identity_group
azuredevops_identity_user

  1. Add timeout
  2. Update test case.
=== RUN   TestAccIdentityUsersDataSource
=== PAUSE TestAccIdentityUsersDataSource
=== CONT  TestAccIdentityUsersDataSource
--- PASS: TestAccIdentityUsersDataSource (10.96s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        15.171s

=== RUN   TestAccIdentityGroupsDataSource
=== PAUSE TestAccIdentityGroupsDataSource
=== CONT  TestAccIdentityGroupsDataSource
--- PASS: TestAccIdentityGroupsDataSource (42.69s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        44.086s

=== RUN   TestAccIdentityGroupDataSource
=== PAUSE TestAccIdentityGroupDataSource
=== CONT  TestAccIdentityGroupDataSource
--- PASS: TestAccIdentityGroupDataSource (42.18s)
PASS
ok      github.com/microsoft/terraform-provider-azuredevops/azuredevops/internal/acceptancetests        43.549s

Does this introduce a change to go.mod, go.sum or vendor/?

  • Yes
  • No

Does this introduce a breaking change?

  • Yes
  • No

Any relevant logs, error output, etc?

(If it’s long, please paste to https://ghostbin.com/ and insert the link here.)

Other information

@xuzhang3 xuzhang3 merged commit ed271d7 into microsoft:main Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant