Update cpp-app template to use ReactNativeAppBuilder #13875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonthysell
reviewed
Sep 18, 2024
| winrt::Microsoft::ReactNative::ReactInstanceSettingsBuilder() | ||
| .DebugBundlePath(L"index") | ||
| .JavaScriptBundleFile(L"index.windows") | ||
| .BundleRootPath(appDirectory) |
There was a problem hiding this comment.
this needs to maintain the file:// prefix from before
There was a problem hiding this comment.
Ah actually this is taken care of in the reactinstancesettingsbuilder.cpp
| // Enable per monitor DPI scaling | ||
| SetProcessDpiAwarenessContext(DPI_AWARENESS_CONTEXT_PER_MONITOR_AWARE_V2); | ||
|
|
||
| // Create a top-level window. |
There was a problem hiding this comment.
While this is an option with the builder, I don't want it in the template. It's fine in the sample app, but for the template i expect people to use the window we give them. and then have the title/resize specified later
| auto reactNativeAppBuilder{winrt::Microsoft::ReactNative::ReactNativeAppBuilder() | ||
| .AddPackageProviders(packageProviders) | ||
| .SetReactInstanceSettings(reactInstanceSettingsBuilder.ReactInstanceSettings()) | ||
| .SetAppWindow(window) |
There was a problem hiding this comment.
As per the above, don't set the window here.
| // Start the react-native instance, which will create a JavaScript runtime and load the applications bundle | ||
| host.ReloadInstance(); | ||
| // Start the react-native instance by creating a javascript runtime and load the bundle. | ||
| auto reactNativeWin32App{reactNativeAppBuilder.Build()}; |
There was a problem hiding this comment.
after building the app, let's use the window getter and set the title / size here.
microsoft-github-policy-service
bot
added
Area: App Template
Area: Fabric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why
Simplify the default template code for creating the fabric app
Resolves #12991
What
Updated the cpp-app template to use ReactNativeAppBuilder
Changelog
Should this change be included in the release notes: yes
Microsoft Reviewers: Open in CodeFlow