-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fabric] Introducing autocapitalize prop in TextInput - Take 2 #13343
base: main
Are you sure you want to change the base?
Conversation
vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
Outdated
Show resolved
Hide resolved
vnext/Microsoft.ReactNative/Fabric/Composition/TextInput/WindowsTextInputComponentView.cpp
Outdated
Show resolved
Hide resolved
}); | ||
test('TextInputs can autocapitalize: Autocapitalize Words', async () => { | ||
|
||
// Test behavior when text is set from JS - Requires change in RN Core repo to avoid override issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What change is needed in RN core? Whats the issue here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously, I set defaultValues to the TextInputs featuring autocapitalization, which are declared in TextInputSharedExamples.js. Doing this caused an "override error" since that .js file is expected to be an exact copy of its parent living in RN Core. IIRC, the source of conflict was here:
\packages\@react-native\tester\overrides.json
"type": "copy",
"directory": "js/examples/TextInput",
"baseDirectory": "packages/rn-tester/js/examples/TextInput",
Description
Type of Change
New feature.
Why
Enables TextInput controls to autocapitalize letters, depending on the selected mode. This PR introduces support for
characters
.words
andsentences
are out of scope, tracked in #13479.Resolves #13120
What
Introduced logic to update the TextInput during updateProps(), to enable/disable all character capitalization.
Testing
Changelog
Yes
Microsoft Reviewers: Open in CodeFlow