chore(visionos): reintroduce no-packager for visionos #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kelset
force-pushed
the
kelset/fix-visionos-packager
branch
from
46e14fc
to
e55cbe9
Compare
tido64
approved these changes
Mar 26, 2024
Saadnajmi
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When testing this PR yesterday #1933 I noticed that the run-visionos command wasn't taking the params. So I went ahead and merged that without the extra param; now Oskar has already taken care of fixing it:
so we can re add it.
Platforms affected
Test plan
Classic test:
yarn installcd examplepod install --project-directory=visionosyarn visionos-> the command won't error out and won't start Metro either