Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AST #2

Merged
merged 16 commits into from
Feb 6, 2023
Merged

Add AST #2

merged 16 commits into from
Feb 6, 2023

Conversation

bamarsha
Copy link
Contributor

@bamarsha bamarsha commented Feb 1, 2023

No description provided.

@bamarsha bamarsha marked this pull request as ready for review February 2, 2023 18:44
@bamarsha bamarsha requested a review from swernli February 2, 2023 18:44
billti
billti reviewed Feb 2, 2023
View reviewed changes
compiler/qsc_ast/src/lib.rs Outdated Show resolved Hide resolved
billti
billti reviewed Feb 2, 2023
View reviewed changes
compiler/qsc_ast/src/lib.rs Outdated Show resolved Hide resolved
billti
billti reviewed Feb 2, 2023
View reviewed changes
compiler/qsc_ast/src/lib.rs Outdated Show resolved Hide resolved
swernli
swernli reviewed Feb 2, 2023
View reviewed changes
compiler/qsc_ast/src/lib.rs Outdated Show resolved Hide resolved
swernli
swernli reviewed Feb 2, 2023
View reviewed changes
compiler/qsc_ast/src/lib.rs Outdated Show resolved Hide resolved
swernli
swernli reviewed Feb 2, 2023
View reviewed changes
compiler/qsc_ast/src/lib.rs Outdated Show resolved Hide resolved
swernli
swernli reviewed Feb 2, 2023
View reviewed changes
compiler/qsc_ast/src/lib.rs Outdated Show resolved Hide resolved
swernli
swernli reviewed Feb 6, 2023
View reviewed changes
compiler/qsc_ast/src/ast.rs Outdated Show resolved Hide resolved
swernli
swernli reviewed Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor updates to comments suggested, otherwise looking close to ready!

swernli
swernli approved these changes Feb 6, 2023
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to go in. We can always refine as we start building components on top of it, though this looks to me like it will be fairly static and the right thing to carry us forward.

@bamarsha bamarsha merged commit 5aef3e6 into main Feb 6, 2023
@bamarsha bamarsha deleted the samarsha/ast branch February 6, 2023 23:06
@swernli swernli mentioned this pull request Mar 9, 2023
Closed
@minestarks minestarks mentioned this pull request Dec 8, 2023
Closed
@ggridin ggridin mentioned this pull request Jun 24, 2024
Closed
@sezna sezna mentioned this pull request Aug 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billti billti billti left review comments

@swernli swernli swernli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bamarsha @billti @swernli