Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse statements and atomic expressions #15

Merged
merged 4 commits into from
Feb 15, 2023
Merged

Parse statements and atomic expressions #15

merged 4 commits into from
Feb 15, 2023

Conversation

bamarsha
Copy link
Contributor

This updates the parser to support statements (let/mutable/use/borrow, and expression statements), and these expressions: blocks, literals, and paths.

@bamarsha bamarsha changed the title Parsing for statements and atomic expressions Parse statements and atomic expressions Feb 15, 2023
@bamarsha bamarsha marked this pull request as ready for review February 15, 2023 01:20
swernli
swernli reviewed Feb 15, 2023
View reviewed changes
Copy link
Collaborator

@swernli swernli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some initial comments as I'm working my way through.

compiler/qsc_frontend/src/parse/stmt.rs Show resolved Hide resolved
compiler/qsc_frontend/src/parse/top.rs Show resolved Hide resolved
compiler/qsc_frontend/src/parse/expr.rs Show resolved Hide resolved
@bamarsha bamarsha merged commit f3b1378 into main Feb 15, 2023
@bamarsha bamarsha deleted the samarsha/stmt-parser branch February 15, 2023 22:59
@swernli swernli mentioned this pull request Mar 9, 2023
Closed
swernli added a commit that referenced this pull request Dec 6, 2023
@swernli
Merge pull request #15 from swernli/swernli/python-tests
91db3e2 
Add RE python tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swernli swernli swernli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bamarsha @swernli