Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

abstract Quote class from Exchange #520

Merged
merged 11 commits into from
Jul 23, 2021
Merged

abstract Quote class from Exchange #520

merged 11 commits into from
Jul 23, 2021

Conversation

wangwenxi-handsome
Copy link
Collaborator

@wangwenxi-handsome wangwenxi-handsome commented Jul 16, 2021 •
edited
Loading

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

you-n-g
you-n-g reviewed Jul 16, 2021
View reviewed changes
qlib/backtest/exchange.py Outdated Show resolved Hide resolved
qlib/backtest/exchange.py Outdated Show resolved Hide resolved
you-n-g
you-n-g reviewed Jul 16, 2021
View reviewed changes
qlib/backtest/exchange.py Outdated Show resolved Hide resolved
you-n-g
you-n-g reviewed Jul 18, 2021
View reviewed changes
qlib/backtest/exchange.py Outdated Show resolved Hide resolved
@you-n-g
Copy link
Collaborator

you-n-g commented Jul 19, 2021

Please resolve the conflictions
image

you-n-g
you-n-g reviewed Jul 22, 2021
View reviewed changes
qlib/backtest/report.py Outdated Show resolved Hide resolved
you-n-g
you-n-g reviewed Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@you-n-g you-n-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job.
A lot of previous details are simplified.

qlib/backtest/report.py Show resolved Hide resolved
qlib/backtest/report.py Outdated Show resolved Hide resolved
qlib/backtest/report.py Outdated Show resolved Hide resolved
qlib/backtest/report.py Outdated Show resolved Hide resolved
qlib/backtest/report.py Show resolved Hide resolved
qlib/backtest/report.py Outdated Show resolved Hide resolved
qlib/backtest/report.py Outdated Show resolved Hide resolved
qlib/backtest/report.py Outdated Show resolved Hide resolved
qlib/backtest/report.py Outdated Show resolved Hide resolved
qlib/backtest/report.py Outdated Show resolved Hide resolved
you-n-g
you-n-g reviewed Jul 22, 2021
View reviewed changes
qlib/backtest/exchange.py Outdated Show resolved Hide resolved
qlib/backtest/report.py Outdated Show resolved Hide resolved
qlib/backtest/report.py Outdated Show resolved Hide resolved
you-n-g
you-n-g reviewed Jul 23, 2021
View reviewed changes
qlib/backtest/high_performance_ds.py Outdated Show resolved Hide resolved
qlib/backtest/high_performance_ds.py Show resolved Hide resolved
qlib/backtest/high_performance_ds.py Outdated Show resolved Hide resolved
qlib/backtest/high_performance_ds.py Outdated Show resolved Hide resolved
qlib/backtest/high_performance_ds.py Show resolved Hide resolved
qlib/backtest/high_performance_ds.py Show resolved Hide resolved
@you-n-g you-n-g merged commit 9e6f4ec into microsoft:nested_decision_exe Jul 23, 2021
qianyun210603 pushed a commit to qianyun210603/qlib that referenced this pull request Mar 23, 2023
@you-n-g
Merge pull request microsoft#520 from wangwenxi-handsome/nested_decis…
12cb519 
…ion_exe

abstract Quote class from Exchange
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you-n-g you-n-g Awaiting requested review from you-n-g

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wangwenxi-handsome @you-n-g