Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add_baostock_collector #1641

Merged
merged 25 commits into from
Nov 21, 2023
Merged

add_baostock_collector #1641

merged 25 commits into from
Nov 21, 2023

Conversation

SunsetWolf
Copy link
Collaborator

Description

Motivation and Context

How Has This Been Tested?

  • Pass the test by running: pytest qlib/tests/test_all_pipeline.py under upper directory of qlib.
  • If you are adding a new feature, test on your own test scripts.

Screenshots of Test Results (if appropriate):

  1. Pipeline test:
  2. Your own tests:

Types of changes

  • Fix bugs
  • Add new feature
  • Update documentation

@github-actions github-actions bot added documentation Improvements or additions to documentation waiting for triage Cannot auto-triage, wait for triage. labels Sep 6, 2023
Fivele-Li
Fivele-Li reviewed Oct 25, 2023
View reviewed changes
scripts/data_collector/baostock_5min/collector.py Outdated Show resolved Hide resolved
scripts/data_collector/baostock_5min/README.md Outdated Show resolved Hide resolved
.github/workflows/test_qlib_from_source.yml Outdated Show resolved Hide resolved
.github/workflows/test_qlib_from_source.yml Show resolved Hide resolved
scripts/data_collector/yahoo/collector.py Outdated Show resolved Hide resolved
scripts/data_collector/utils.py Outdated Show resolved Hide resolved
@SunsetWolf SunsetWolf mentioned this pull request Nov 17, 2023
Open
you-n-g
you-n-g reviewed Nov 21, 2023
View reviewed changes
scripts/data_collector/utils.py
consistent_1d: bool = True,
calc_paused: bool = True,
) -> pd.DataFrame:
# TODO: using daily data factor
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More document for this function

scripts/data_collector/utils.py


def calc_paused_num(df: pd.DataFrame, _date_field_name, _symbol_field_name):
_symbol = df.iloc[0][_symbol_field_name]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More document for this function

@you-n-g you-n-g merged commit 98f569e into main Nov 21, 2023
22 of 32 checks passed
@you-n-g you-n-g deleted the baostock_collector branch November 21, 2023 12:32
@SunsetWolf SunsetWolf mentioned this pull request Nov 23, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@you-n-g you-n-g you-n-g left review comments

@Fivele-Li Fivele-Li Fivele-Li left review comments

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation waiting for triage Cannot auto-triage, wait for triage.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@SunsetWolf @you-n-g @Fivele-Li