chore: identify largest gaps in Bidi API #32434
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| @@ -0,0 +1,95 @@ | |||
| /** | |||
There was a problem hiding this comment.
Is there a way to avoid duping this?
There was a problem hiding this comment.
I'd prefer to keep the config separate from other browsers as there are too many vailing tests in bidi and it's unclear when the spec/implementation will get to the state where we could make the tests pass.
| @@ -98,6 +98,8 @@ export interface PageDelegate { | |||
| resetForReuse(): Promise<void>; | |||
| // WebKit hack. | |||
| shouldToggleStyleSheetToSyncAnimations(): boolean; | |||
| // Bidi throws on attempt to document.open() in utility context. | |||
| useMainWorldForSetContent?(): boolean; | |||
There was a problem hiding this comment.
I don't think we should make these shortcuts in shared classes. If you are looking for the ways to unblock the tests, maybe it makes sense to move this into the delegate? Can be a common base class or a utility for chromium/webkit/firefox.
| await this._performActions([{ type: 'pointerUp', button: toBidiButton(button) }]); | ||
| } | ||
|
|
||
| async click(x: number, y: number, options: { delay?: number, button?: types.MouseButton, clickCount?: number } = {}) { |
There was a problem hiding this comment.
Do the same to the other ports to have click everywhere?
| @@ -216,6 +217,8 @@ export class Mouse { | |||
| async click(x: number, y: number, options: { delay?: number, button?: types.MouseButton, clickCount?: number } = {}, metadata?: CallMetadata) { | |||
| if (metadata) | |||
| metadata.point = { x: this._x, y: this._y }; | |||
| if (this._raw.click) | |||
There was a problem hiding this comment.
Let's add a test that page.mouse.down + page.mouse.up generate click and disable it for bidi.
| if (object.type === 'event') { | ||
| // Route page events to the right session. | ||
| let context; | ||
| if ('context' in object.params) |
There was a problem hiding this comment.
Consider having a single browser-wide session, and choose a page/context/frame in each event handler separately.
| this._page._frameManager.frameRequestedNavigation(frameId, params.navigation!); | ||
|
|
||
| const url = params.url.toLowerCase(); | ||
| if (url.startsWith('file:') || url.startsWith('data:') || url === 'about:blank') { |
There was a problem hiding this comment.
Let's add a test for a navigation to blob url.
|
|
||
| async getContentFrame(handle: dom.ElementHandle): Promise<frames.Frame | null> { | ||
| const executionContext = toBidiExecutionContext(handle._context); | ||
| const contentWindow = await executionContext.rawCallFunction('e => e.contentWindow', { handle: handle._objectId }); |
There was a problem hiding this comment.
Let's add a test that this works for cross-process iframes.
| if (!parent) | ||
| throw new Error('Frame has been detached.'); | ||
| const parentContext = await parent._mainContext(); | ||
| const list = await parentContext.evaluateHandle(() => { return [...document.querySelectorAll('iframe,frame')]; }); |
There was a problem hiding this comment.
Let's add a test for getFrameElement() where iframe is inside shadow dom.
This pull request introduces initial support for the WebDriver BiDi protocol in Playwright. The primary goal of this PR is not to fully implement BiDi but to experiment with the current state of the specification and its implementation. We aim to identify the biggest gaps and challenges that need to be addressed before considering BiDi as the main protocol for Playwright.
Test results for "tests 1"1 failed 2 flaky29536 passed, 637 skipped Merge workflow run. |
Adding some tests discussed in microsoft#32434
Adding some tests discussed in #32434
This pull request introduces initial support for the WebDriver BiDi protocol in Playwright. The primary goal of this PR is not to fully implement BiDi but to experiment with the current state of the specification and its implementation. We aim to identify the biggest gaps and challenges that need to be addressed before considering BiDi as the main protocol for Playwright.