chore: move artifacts recording to TestLifecycleInstrumentation

[dgozman]

The spirit of this change is reverting #23153. Since that time, we have moved tracing and artifactsDir lifetime into the test runner, so the reason for revert is mitigated.

Fixes #30287, fixes #30718, fixes #30959.

[github-actions]

Test results for "tests 2"

6 fatal errors, not part of any test
8 failed
❌ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body
❌ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body
❌ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:340:7 › cli codegen › should record open in a new tab with url
❌ [chromium-library] › library/browsertype-connect.spec.ts:642:5 › run-server › should fulfill with global fetch result
❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas

68 flaky

⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:790:7 › cli codegen › should click button with nested div
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:502:7 › cli codegen › should generate getByLabel without regex
⚠️ [chromium-page] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:246:5 › Drag and drop › should work if the drag event is captured but not canceled
⚠️ [chromium-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:111:5 › should print load/save storageState
⚠️ [chromium-library] › library/selector-generator.spec.ts:565:5 › selector generator › should generate multiple: noId
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/page-mouse.spec.ts:147:3 › should select the text with mouse
⚠️ [firefox-library] › library/video.spec.ts:165:5 › screencast › should work with old options
⚠️ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body
⚠️ [firefox-library] › library/browsercontext-add-cookies.spec.ts:141:3 › should isolate persistent cookies
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:46:3 › should click with disabled javascript
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:128:3 › should not leak listeners during navigation of 20 pages
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:932:3 › launchServer only › should be able to reconnect to a browser 12 times without warnings
⚠️ [firefox-library] › library/capabilities.spec.ts:22:3 › SharedArrayBuffer should work @smoke
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should ignore programmatic events
⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:76:7 › cli codegen › should click after same-document navigation
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:138:7 › cli codegen › should upload multiple files
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:200:7 › cli codegen › should download files
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:57:7 › cli codegen › should click locator.nth
⚠️ [firefox-library] › library/trace-viewer.spec.ts:822:1 › should include requestUrl in route.fulfill
⚠️ [firefox-library] › library/tracing.spec.ts:292:5 › should overwrite existing file
⚠️ [firefox-page] › page/page-click.spec.ts:99:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body
⚠️ [firefox-library] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body
⚠️ [firefox-library] › library/permissions.spec.ts:103:5 › permissions › should trigger permission onchange
⚠️ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames crop
⚠️ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1142:3 › should work with connectOverCDP
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:381:5 › launchServer › should emit close events on pages and contexts
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work
⚠️ [chromium-library] › library/chromium/connect-over-cdp.spec.ts:26:5 › should connect to an existing cdp session
⚠️ [chromium-library] › library/chromium/launcher.spec.ts:28:3 › should not throw with remote-debugging-port argument
⚠️ [chromium-library] › library/downloads-path.spec.ts:32:5 › downloads path › should keep downloadsPath folder
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:502:7 › cli codegen › should save assets via SIGINT
⚠️ [chromium-library] › library/tracing.spec.ts:350:5 › should survive browser.close with auto-created traces dir
⚠️ [chromium-page] › page/page-add-locator-handler.spec.ts:90:5 › should work with locator.hover()
⚠️ [chromium-page] › page/page-drag.spec.ts:25:5 › Drag and drop › should work @smoke
⚠️ [chromium-page] › page/page-drag.spec.ts:53:5 › Drag and drop › should not send dragover on the first mousemove
⚠️ [chromium-page] › page/page-drag.spec.ts:70:5 › Drag and drop › should work inside iframe
⚠️ [chromium-page] › page/page-mouse.spec.ts:221:3 › should tween mouse movement
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [firefox-page] › page/page-request-continue.spec.ts:481:3 › continue should not change multipart/form-data body
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context
⚠️ [webkit-page] › page/page-drag.spec.ts:34:5 › Drag and drop › should send the right events
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:258:7 › cli codegen › should fill japanese text
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:668:7 › cli codegen › should assert navigation
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:143:12 › should drag with high dpi
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:106:7 › cli codegen › should make a positioned click on a canvas
⚠️ [webkit-library] › library/trace-viewer.spec.ts:807:1 › should open two trace files of the same test
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline
⚠️ [webkit-page] › page/page-request-continue.spec.ts:196:5 › post data › should compute content-length from post data
⚠️ [webkit-page] › page/locator-misc-2.spec.ts:27:3 › should scroll into view
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:626:7 › cli codegen › should await popup
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

182805 passed, 8002 skipped, 2651 did not run
✔️✔️✔️

Merge workflow run.

[github-actions]

Test results for "tests 1"

2 flaky

⚠️ [chromium-page] › page/page-set-input-files.spec.ts:434:3 › should detect mime type
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots

27088 passed, 608 skipped
✔️✔️✔️

Merge workflow run.