Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "fix(reuse): reset Origin Private File System API (#29921)" #30342

Conversation

mxschmitt
Copy link
Member

@mxschmitt mxschmitt commented Apr 11, 2024

This reverts commit 048d666.

This change caused the crash for #30339 (comment). If we don't execute this code, it does not crash.

Reverting it for now until the Chromium fix lands in Beta/Stable.

Copy link
Contributor

Test results for "tests 1"

9 flaky ⚠️ [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [firefox-page] › page/page-click-timeout-4.spec.ts:20:3 › should timeout waiting for stable position
⚠️ [playwright-test] › ui-mode-test-progress.spec.ts:165:5 › should update tracing network live
⚠️ [chromium-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks
⚠️ [playwright-test] › ui-mode-test-screencast.spec.ts:21:5 › should show screenshots
⚠️ [webkit-library] › library/tracing.spec.ts:243:5 › should not include trace resources from the previous chunks

26944 passed, 619 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 96053ed into microsoft:main Apr 11, 2024
30 checks passed
mxschmitt pushed a commit that referenced this pull request Apr 11, 2024
…stem API (#29921)" (#30344)

This PR cherry-picks the following commits:

- 96053ed

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants