Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for issue #1767 #1869

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix for issue #1767 #1869

wants to merge 1 commit into from

Commits on May 10, 2023

  1. Fix for issue microsoft#1767 

    This change updates GetActiveSessionNames to check for ERROR_MORE_DATA and retry once when calling QueryAllTraces.

I chose to implement this by modifying the current function as little as possible. To do that, I wrapped the core logic and made a recursive call to it for the retry, with a depth counter that maxes out at 1.

This change also has a unit test, but I don't think it is ready to be comitted. I am including it so a discussion can be had. In general it seems hard to reliably simulate this condition on a broad set of machines that will run this test suite (65+ active etw sessions while EtwMaxLoggers registry key is not set.)
    ryandle committed May 10, 2023
    Configuration menu
    Copy the full SHA
    4bdbd45 View commit details
    Browse the repository at this point in the history