Skip to content
This repository has been archived by the owner on Nov 1, 2023. It is now read-only.

Remove feature flag from heartbeat metrics. #3505

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Remove feature flag from heartbeat metrics. #3505

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ef41e84
Remove feature flag from heartbeat metrics.
nharper285 Sep 14, 2023
5514ab3
Merge branch 'main' into user/noharper/remove-metric-feature-falg
nharper285 Sep 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/ApiService/ApiService/Functions/QueueNodeHeartbeat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,8 @@ public async Async.Task Run([QueueTrigger("node-heartbeat", Connection = "AzureW
var nodeHeartbeatEvent = new EventNodeHeartbeat(node.MachineId, node.ScalesetId, node.PoolName, node.State);
// TODO: do we still send event if we fail do update the table ?
await events.SendEvent(nodeHeartbeatEvent);
if (await _context.FeatureManagerSnapshot.IsEnabledAsync(FeatureFlagConstants.EnableCustomMetricTelemetry)) {
metrics.SendMetric(1, nodeHeartbeatEvent);
}
metrics.SendMetric(1, nodeHeartbeatEvent);


}
}
5 changes: 2 additions & 3 deletions src/ApiService/ApiService/Functions/QueueTaskHeartbeat.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,7 @@ public async Async.Task Run([QueueTrigger("task-heartbeat", Connection = "AzureW

var taskHeartBeatEvent = new EventTaskHeartbeat(newTask.JobId, newTask.TaskId, job.Config.Project, job.Config.Name, newTask.State, newTask.Config);
await _events.SendEvent(taskHeartBeatEvent);
if (await _context.FeatureManagerSnapshot.IsEnabledAsync(FeatureFlagConstants.EnableCustomMetricTelemetry)) {
_metrics.SendMetric(1, taskHeartBeatEvent);
}
_metrics.SendMetric(1, taskHeartBeatEvent);

}
}
Loading