Added a missing unlock in getDestinationMetadata()
#2484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
barryw-mssql
previously approved these changes
Aug 6, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2484 +/- ##
============================================
+ Coverage 50.78% 50.80% +0.01%
- Complexity 3888 3890 +2
============================================
Files 145 145
Lines 33481 33482 +1
Branches 5690 5691 +1
============================================
+ Hits 17004 17010 +6
+ Misses 14030 14028 -2
+ Partials 2447 2444 -3 ☔ View full report in Codecov by Sentry. |
David-Engel
reviewed
Aug 6, 2024
src/main/java/com/microsoft/sqlserver/jdbc/SQLServerBulkCopy.java
Outdated
Show resolved
Hide resolved
|
Also, you should add a test to cover the scenario that the reporting issue manifests. |
barryw-mssql
previously approved these changes
Aug 8, 2024
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Outdated
Show resolved
Hide resolved
barryw-mssql
previously approved these changes
Aug 14, 2024
tkyc
previously approved these changes
Aug 14, 2024
src/test/java/com/microsoft/sqlserver/jdbc/unit/statement/BatchExecutionTest.java
Outdated
Show resolved
Hide resolved
lilgreenbird
approved these changes
Aug 19, 2024
lilgreenbird
previously requested changes
Aug 19, 2024
lilgreenbird
approved these changes
Aug 19, 2024
barryw-mssql
approved these changes
Aug 20, 2024
tkyc
pushed a commit
that referenced
this pull request
Aug 21, 2024
* Added a missing unlock * Clean up locks as per pr review * Added test * Resolve codeql error * Extend timeout time * Removing test to narrow down on pipeline failures * Adding a clear to see if this fixes prior errors * PR review changes * Address PR comments * More
tkyc
added a commit
that referenced
this pull request
Aug 22, 2024
* Added a missing unlock * Clean up locks as per pr review * Added test * Resolve codeql error * Extend timeout time * Removing test to narrow down on pipeline failures * Adding a clear to see if this fixes prior errors * PR review changes * Address PR comments * More Co-authored-by: Jeff Wasty <v-jeffwasty@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.