Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging info to token caching #2468

Merged
merged 1 commit into from
Jul 3, 2024
Merged

Add logging info to token caching #2468

merged 1 commit into from
Jul 3, 2024

Conversation

lilgreenbird
Copy link
Member

No description provided.

@lilgreenbird lilgreenbird changed the title update Add logging info to token caching Jul 3, 2024
@lilgreenbird lilgreenbird added this to the 12.7.1 milestone Jul 3, 2024
@lilgreenbird lilgreenbird merged commit 285f4f6 into main Jul 3, 2024
17 checks passed
David-Engel
David-Engel reviewed Jul 5, 2024
View reviewed changes
Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: I would have done FINER logging here. This isn't a hot path and it seems silly to require FINEST logging (with all the packet logging that comes with) to get this info for troubleshooting.

@Jeffery-Wasty Jeffery-Wasty deleted the tokencache branch July 30, 2024 20:01
@Eng-Fouad Eng-Fouad mentioned this pull request Aug 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@David-Engel David-Engel David-Engel left review comments

@Jeffery-Wasty Jeffery-Wasty Jeffery-Wasty approved these changes

@tkyc tkyc tkyc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
12.7.1
Development

Successfully merging this pull request may close these issues.
4 participants
@lilgreenbird @Jeffery-Wasty @David-Engel @tkyc