Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVN reference in policy readme #1877

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

BryceDFisher
Copy link
Contributor

SVNs are integers, not semantic version numbers.

@BryceDFisher BryceDFisher requested a review from a team as a code owner August 23, 2023 16:48
@helsaawy
Copy link
Contributor

test failure is unrelated, but you will need to force push after signing the commit (git commit --amend --no-edit -s)

@BryceDFisher
Copy link
Contributor Author

test failure is unrelated, but you will need to force push after signing the commit (git commit --amend --no-edit -s)

Done

Signed-off-by: Bryce Fisher <bryce.fisher@live.com>
@helsaawy
Copy link
Contributor

LGTM (assuming tests all pass after the rebase) feel free to merge when its all green :)

@helsaawy helsaawy merged commit 3d1810e into microsoft:main Aug 24, 2023
16 checks passed
@BryceDFisher BryceDFisher deleted the fix_svn_reference branch August 25, 2023 19:01
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
Signed-off-by: Bryce Fisher <bryce.fisher@live.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants