Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: rego get_properties functional test #1803

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Jun 5, 2023

Update test images package to support image extract decorators as an easy way to extend the logic if we need to chain a few steps, in this case appending verity hashes to an ext4 fs.

Add default mount extension logic to standalone container path as well to enable functional tests.

Add new securitypolicy package under test/pkg to share some logic between cri-containerd and functional tests.

Add lower level get_properties test with rego policies.

@anmaxvl anmaxvl requested a review from a team as a code owner June 5, 2023 22:21
test/cri-containerd/policy_test.go Show resolved Hide resolved
test/functional/lcow_policy_test.go Outdated Show resolved Hide resolved
test/internal/layers/lazy.go Show resolved Hide resolved
@helsaawy
Copy link
Contributor

helsaawy commented Jun 5, 2023

overall LGTM

Update test images package to support image extract decorators
as an easy way to extend the logic if we need to chain a few
steps, in this case appending verity hashes to an ext4 fs.

Add default mount extension logic to standalone container path
as well to enable functional tests.

Add new `securitypolicy` package under `test/pkg` to share
some logic between cri-containerd and functional tests.

Add lower level `get_properties` test with rego policies.

Signed-off-by: Maksim An <maksiman@microsoft.com>
Copy link
Contributor

@msscotb msscotb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anmaxvl anmaxvl merged commit 55417ac into microsoft:main Jul 24, 2023
16 checks passed
@anmaxvl anmaxvl deleted the tests/rego-functional branch July 24, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants