Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure to close files in dmverity-vhd tool #1770

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented May 11, 2023

Currently we're not closing output VHD files and read closers when creating layer VHDs with dmverity-vhd tool.

Refactor error wrapping.

@anmaxvl anmaxvl requested a review from a team as a code owner May 11, 2023 20:26
cmd/dmverity-vhd/main.go Outdated Show resolved Hide resolved
Currently we're not closing output VHD files and read closers
when creating layer VHDs with dmverity-vhd tool.

Refactor error wrapping.

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl merged commit 567f6bd into microsoft:main Jul 19, 2023
@anmaxvl anmaxvl deleted the close-files-dmverity-vhd branch July 19, 2023 19:36
anmaxvl added a commit to anmaxvl/hcsshim that referenced this pull request Oct 23, 2023
Currently we're not closing output VHD files and read closers
when creating layer VHDs with dmverity-vhd tool.

Refactor error wrapping.

Signed-off-by: Maksim An <maksiman@microsoft.com>
(cherry picked from commit 567f6bd)
anmaxvl added a commit that referenced this pull request Oct 30, 2023
Currently we're not closing output VHD files and read closers
when creating layer VHDs with dmverity-vhd tool.

Refactor error wrapping.

Signed-off-by: Maksim An <maksiman@microsoft.com>
(cherry picked from commit 567f6bd)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants