-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: bug potentially not removing RW device. #1737
Conversation
internal/guest/runtime/hcsv2/uvm.go
Outdated
@@ -538,7 +538,7 @@ func (h *Host) CreateContainer(ctx context.Context, id string, settings *prot.VM | |||
return c, nil | |||
} | |||
|
|||
func (h *Host) modifyHostSettings(ctx context.Context, containerID string, req *guestrequest.ModificationRequest) (err error) { | |||
func (h *Host) modifyHostSettings(ctx context.Context, containerID string, req *guestrequest.ModificationRequest) (retErr error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm missing where retErr
is ever written to?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, interesting. The retErr
is assigned to as part of the return. For anyone else confused like I was:
https://go.dev/play/p/IDH-93ODPLs
Signed-off-by: Maksim An <maksiman@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Maksim An <maksiman@microsoft.com>
No description provided.