Adding policy for Linux capabilities. #1683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matajoh
commented
Mar 5, 2023
anmaxvl
reviewed
Mar 7, 2023
anmaxvl
reviewed
Mar 9, 2023
anmaxvl
reviewed
Mar 10, 2023
anmaxvl
approved these changes
Mar 14, 2023
|
@anmaxvl should we squash this now? |
helsaawy
reviewed
Mar 15, 2023
| if len(caps.Bounding) > 0 { | ||
| out["bounding"] = caps.Bounding | ||
| } else { | ||
| out["bounding"] = make([]string, 0) | ||
| } |
There was a problem hiding this comment.
in all these cases, caps.Bounding and co should be equivalent to make([]string, 0) if len() == 0.
Is there a reason why we need to make a new slice in that case?
There was a problem hiding this comment.
because it can be nil which is still a 0 for size (thanks go!) but then we have to deal with nil and empty list down the road.
There was a problem hiding this comment.
ohhh, yeah .....
can you add a comment above L504 to the effect of // create new empty []string in case caps has nil array?
There was a problem hiding this comment.
I have added this comment and squashed the branch.
helsaawy
approved these changes
Mar 15, 2023
This commit adds enforcement of policy over the capabilities provided to a process, either the init process of the container, or a process being executed inside a container (*i.e.* this affects the `EnforceCreateContainerPolicy` and `EnforceExecInContainerPolicy` enforcement points). Linux capabilities enumerate the things a process can do, and as such a malicious host could grant or deny specific capabilities to processes to create an unexpected and potentially compromised state for the container group. Users can now specify an exact list of capabilities for each of the five sets (bounding, effective, inheritable, permitted, and ambient). Users can also specify that they wish to enable *capabilities dropping*, whereby any extraneous capabilities which are granted by the host can be dropped down to a minimum set of needed capabilities. Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
And pick up defaults from runtime Signed-off-by: Sean T. Allen <seanallen@microsoft.com>
anmaxvl
approved these changes
Mar 16, 2023
Signed-off-by: Matthew A Johnson <matjoh@microsoft.com>
|
hm. forgot that if you resolve the merge conflicts through github UI it does a merge. we should be fine though. I'll just squash merge. |
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
This commit adds enforcement of policy over the capabilities provided to a process, either the init process of the container, or a process being executed inside a container (*i.e.* this affects the `EnforceCreateContainerPolicy` and `EnforceExecInContainerPolicy` enforcement points). Linux capabilities enumerate the things a process can do, and as such a malicious host could grant or deny specific capabilities to processes to create an unexpected and potentially compromised state for the container group. Users can now specify an exact list of capabilities for each of the five sets (bounding, effective, inheritable, permitted, and ambient). Users can also specify that they wish to enable *capabilities dropping*, whereby any extraneous capabilities which are granted by the host can be dropped down to a minimum set of needed capabilities. Signed-off-by: Matthew A Johnson <matjoh@microsoft.com> Signed-off-by: Sean T. Allen <seanallen@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds enforcement of policy over the capabilities provided to a process, either the init process of the container, or a process being executed inside a container (i.e. this affects the
EnforceCreateContainerPolicyandEnforceExecInContainerPolicyenforcement points). Linux capabilities enumerate the things a process can do, and as such a malicious host could grant or deny specific capabilities to processes to create an unexpected and potentially compromised state for the container group. Users can now specify an exact list of capabilities for each of the five sets (bounding, effective, inheritable, permitted, and ambient).Users can also specify that they wish to enable capabilities dropping, whereby any extraneous capabilities which are granted by the host can be dropped down to a minimum set of needed capabilities.