Add retry to install mingw #1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anmaxvl
approved these changes
Jan 30, 2023
helsaawy
force-pushed
the
integration-test-mingw
branch
6 times, most recently
from
e2ecb06
to
2cd4d6a
Compare
Integration test often fails because of mingw installation failure, which in turn appears to be a web-request issues. Adding rety and backoff/sleep to resolve issue. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
helsaawy
force-pushed
the
integration-test-mingw
branch
from
2cd4d6a
to
135be44
Compare
| Write-Output 'Install mingw' | ||
| # Install sometimes fails when downloading mingw zip from source-forge with: | ||
| # "ERROR: The remote file either doesn't exist, is unauthorized, or is forbidden for url" | ||
| # Issue is with accessing from source-forge, which version 10.3+ do not use, but cannot upgrade versions. |
There was a problem hiding this comment.
Not sure I understand this sentence. Are you saying that we can't update to 10.3+?
There was a problem hiding this comment.
yeah, the integration tests fail when running the race detector
https://github.com/microsoft/hcsshim/actions/runs/4050036368/jobs/6967108412
it may be fixed in newer go versions, but for now i want to hold the version to avoid mucking around with the tests
katiewasnothere
approved these changes
Jan 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integration test often fails because of mingw installation failure, which in turn appears to be a web-request issues.
Adding rety and backoff/sleep to resolve issue.
Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com