Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing AllowElevated policy check when creating a container #1624

Merged
merged 2 commits into from
Jan 27, 2023
Merged

Add missing AllowElevated policy check when creating a container #1624

merged 2 commits into from
Jan 27, 2023

Commits on Jan 23, 2023

  1. Add missing AllowElevated policy check when creating a container

    When we added AllowElevated and checked it was working correctly, we
    got it slightly wrong. When a container is started, we were adding in
    expected mounts that only happen for privileged containers and
    using those are mounts that are allowed.
    
    During testing, if AllowElevated was left off, a privileged container
    would fail to start seemingly indicating that all was good. However,
    all was not good.
    
    A malicious orchestrator with control of the API could create a container
    privileged that didn't contain any extra "privileged mounts" and the
    container would start as privileged with everything else that being
    privileged entails except for the mounts.
    
    This commit adds an explicit check as part of crete container to verify
    that is the container is attempting to be started as privileged that it
    has AllowElevated.
    
    Maksim and I both thought that this had been implemented. I remember it
    being implemented. Apparently that memory is incorrect. Either way, it
    was noticed last Thursday and here's the fix.
    
    Signed-off-by: Sean T. Allen <seanallen@microsoft.com>
    SeanTAllen committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    b2a57d0 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. update policy e2e test with correct error string expectation

    Signed-off-by: Maksim An <maksiman@microsoft.com>
    anmaxvl committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    040e0a8 View commit details
    Browse the repository at this point in the history