race condition with exitCh in (*UtilityVM).Start()
#1562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`(*UtilityVM).acceptAndClose()` waits on `(*UtilityVM).exitCh`, but `exitCh` is not created until after the goroutines with the `acceptAndClose` calls are launched, causing a potential race condition. Functional and cri-containerd tests pass. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
anmaxvl
approved these changes
Nov 14, 2022
kiashok
approved these changes
Nov 14, 2022
anmaxvl
pushed a commit
that referenced
this pull request
Feb 7, 2023
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
`(*UtilityVM).acceptAndClose()` waits on `(*UtilityVM).exitCh`, but `exitCh` is not created until after the goroutines with the `acceptAndClose` calls are launched, causing a potential race condition. Functional and cri-containerd tests pass. Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com> Signed-off-by: Hamza El-Saawy <hamzaelsaawy@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(*UtilityVM).acceptAndClose()waits on(*UtilityVM).exitCh, butexitChis not created until after the goroutines with theacceptAndClosecalls are launched, causing a potential race condition.Signed-off-by: Hamza El-Saawy hamzaelsaawy@microsoft.com