Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deferred os.Umask usage in loops #1256

Merged
merged 1 commit into from
Dec 30, 2021

Conversation

anmaxvl
Copy link
Contributor

@anmaxvl anmaxvl commented Dec 29, 2021

Signed-off-by: Maksim An maksiman@microsoft.com

@anmaxvl anmaxvl requested a review from a team as a code owner December 29, 2021 18:27
@dcantah
Copy link
Contributor

dcantah commented Dec 29, 2021

'Fix deferred os.Umask usage in loops' might be clearer as there's two fixes here.

Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Maksim An <maksiman@microsoft.com>
@anmaxvl anmaxvl changed the title Fix deferred os.Umask call inside a for loop Fix deferred os.Umask usage in loops Dec 29, 2021
@helsaawy
Copy link
Contributor

lgtm

@anmaxvl anmaxvl merged commit 42d6961 into microsoft:master Dec 30, 2021
@anmaxvl anmaxvl deleted the fix/mkdirall-modeperm branch December 30, 2021 21:04
princepereira pushed a commit to princepereira/hcsshim that referenced this pull request Aug 29, 2024
Signed-off-by: Maksim An <maksiman@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants