Revendor in /test and remove dead code #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Somehow after the last two check-in's the CI (specifically our linter) started whining about ext4BlockSize being dead code. With the last check-in to master our verify-test-vendor step also somehow didn't catch that /internal/winapi/process.go was updated and needed to be pulled in. This change fixes both of those issues. Signed-off-by: Daniel Canter <dcanter@microsoft.com>
anmaxvl
approved these changes
Dec 15, 2021
No worries at all, somehow our CI didn't catch either at PR time, only did after check-in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow after the last two check-in's the CI (specifically our linter)
started whining about ext4BlockSize being dead code. The last PR
to master our verify-test-vendor step also somehow didn't catch that
/internal/winapi/process.go was updated and needed to be pulled in, but it
did after check-in This change fixes both of those issues.
Signed-off-by: Daniel Canter dcanter@microsoft.com