Set default time zone for WCOW UVM #1192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcantah
force-pushed
the
timezone_wcow
branch
2 times, most recently
from
ef3ad3a
to
570cb77
Compare
|
Gonna draft again until I can get something answered |
kevpar
reviewed
Nov 11, 2021
internal/uvm/timezone.go
Outdated
| StandardName: "GMT Standard Time", | ||
| StandardBias: 0, | ||
| DaylightName: "GMT Daylight Time", | ||
| DaylightBias: -60, |
There was a problem hiding this comment.
You mentioned also finding info on a "UTC" time zone. Did that one have DST? I would rather we use something that doesn't have DST if we can find a good standard.
There was a problem hiding this comment.
It does not iirc, I'm working to swap it over and rebase this PR right now
There was a problem hiding this comment.
Done, using UTC now instead.
dcantah
force-pushed
the
timezone_wcow
branch
2 times, most recently
from
e441028
to
c672838
Compare
|
I've sinned and force pushed, but to be fair this is the first time it's been out of draft for review 😝 |
For the v2 hcs code paths it seems the only time a time zone is set is if a new field on the guest connection settings is present (which we don't have) while using the internal guest connection (shim -> hcs -> gcs). Otherwise the guest is just left without a time zone set, so things like tzutil or the get-timezone powershell cmdlet will return an invalid time zone set. We swapped to always using the external guest connection we maintain in the shim so we need to set a time zone explicitly. This change issues a request to the gcs to set a timezone via the same method that hcs uses internally. It sets the guests time zone to whatever is present on the host which is the docker behavior, and then all containers in the vm should inherit this. Additionally expose an option to override this behavior and just set the time zone to GMT. If the container wants to change its timezone to something else, it is free to on supported images. See https://docs.microsoft.com/en-us/virtualization/windowscontainers/manage-containers/virtual-time-zone Signed-off-by: Daniel Canter <dcanter@microsoft.com>
dcantah
force-pushed
the
timezone_wcow
branch
from
c672838
to
78d7419
Compare
|
Fixing merge conflicts after Amit's chronyd change got in |
anmaxvl
approved these changes
Nov 16, 2021
|
lgtm |
princepereira
pushed a commit
to princepereira/hcsshim
that referenced
this pull request
Aug 29, 2024
For the v2 hcs code paths it seems the only time a time zone is set is if a new field on the guest connection settings is present (which we don't have) while using the internal guest connection (shim -> hcs -> gcs). Otherwise the guest is just left without a time zone set, so things like tzutil or the get-timezone powershell cmdlet will return an invalid time zone set. We swapped to always using the external guest connection we maintain in the shim so we need to set a time zone explicitly. This change issues a request to the gcs to set a timezone via the same method that hcs uses internally. It sets the guests time zone to whatever is present on the host which is the docker behavior, and then all containers in the vm should inherit this. Additionally expose an option to override this behavior and just set the time zone to UTC. If the container wants to change its time zone to something else, it is free to on supported images. See https://docs.microsoft.com/en-us/virtualization/windowscontainers/manage-containers/virtual-time-zone Signed-off-by: Daniel Canter <dcanter@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the v2 hcs code paths it seems the only time a time zone is set is if
a new field on the guest connection settings is present (which we don't have)
while using the internal guest connection (shim -> hcs -> gcs). Otherwise
the guest is just left without a time zone set, so things like tzutil or
the get-timezone powershell cmdlet will return an invalid time zone set.
We swapped to always using the external guest connection we maintain in the
shim so we need to set a time zone explicitly.
This change issues a request to the gcs to set a timezone via the same method that
hcs uses internally. It sets the guests time zone to whatever is present on
the host which is the docker behavior, and then all containers in the vm
should inherit this. If the container wants to change its timezone it can
do so if it's on a supported sku.
See https://docs.microsoft.com/en-us/virtualization/windowscontainers/manage-containers/virtual-time-zone
Signed-off-by: Daniel Canter dcanter@microsoft.com