Update json format for security policy #1173

SeanTAllen · 2021-09-22T14:31:49Z

These changes come by way of a suggestion from Maksim who noted that this
new format keeps the same information as the previous format, but organizes
it in a way that makes it easier to maintain the creation code and can
allow for the usage of a custom JSON marshaller to remove a source
of possible bugs in keeping the number of elements and the field that
is the length of said elements in sync,

Signed-off-by: Sean T. Allen seanallen@microsoft.com

internal/tools/securitypolicy/main.go

pkg/securitypolicy/securitypolicy.go

SeanTAllen · 2021-09-24T12:16:23Z

@dcantah PTAL

pkg/securitypolicy/securitypolicyenforcer.go

internal/tools/securitypolicy/main.go

dcantah · 2021-09-25T07:24:59Z

The README should be updated with an example showing what the tool would spit out for the new format now

SeanTAllen · 2021-09-27T14:39:19Z

@dcantah README has been updated.

SeanTAllen · 2021-09-27T14:43:13Z

@dcantah PTAL (please take another look)

dcantah · 2021-09-28T08:45:16Z

@SeanTAllen Sorry for the delay!

dcantah · 2021-09-28T08:46:34Z

Oh oop spoke too soon

pkg/securitypolicy/securitypolicyenforcer.go

These changes come by way of a suggestion from Maksim who noted that this new format keeps the same information as the previous format, but organizes it in a way that makes it easier to maintain the creation code and can allow for the usage of a custom JSON marshaller to remove a source of possible bugs in keeping the number of elements and the field that is the length of said elements in sync, Signed-off-by: Sean T. Allen <seanallen@microsoft.com>

dcantah · 2021-09-28T12:05:26Z

Ok re-lgtm

Related work items: microsoft#1062, microsoft#1087, microsoft#1089, microsoft#1095, microsoft#1104, microsoft#1112, microsoft#1117, microsoft#1118, microsoft#1125, microsoft#1137, microsoft#1139, microsoft#1140, microsoft#1141, microsoft#1142, microsoft#1143, microsoft#1145, microsoft#1146, microsoft#1150, microsoft#1151, microsoft#1153, microsoft#1154, microsoft#1155, microsoft#1156, microsoft#1157, microsoft#1158, microsoft#1159, microsoft#1161, microsoft#1162, microsoft#1163, microsoft#1164, microsoft#1165, microsoft#1166, microsoft#1167, microsoft#1168, microsoft#1169, microsoft#1171, microsoft#1172, microsoft#1173, microsoft#1174, microsoft#1178

…n-format Update json format for security policy

SeanTAllen requested a review from a team as a code owner September 22, 2021 14:31

anmaxvl self-assigned this Sep 22, 2021

anmaxvl reviewed Sep 22, 2021

View reviewed changes

internal/tools/securitypolicy/main.go Show resolved Hide resolved

anmaxvl reviewed Sep 22, 2021

View reviewed changes

pkg/securitypolicy/securitypolicy.go Show resolved Hide resolved

anmaxvl approved these changes Sep 24, 2021

View reviewed changes

dcantah self-assigned this Sep 25, 2021