Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test network agent for ncproxy dev work #1067

Merged

Conversation

katiewasnothere
Copy link
Contributor

@katiewasnothere katiewasnothere commented Jul 9, 2021

This PR contains a test version of a vnetagent that we can use locally when doing dev work with ncproxy. This is not meant to be used outside of a testing environment.

This PR additionally updates cmd/ncproxy/nodenetsvc/nodenetsvc.proto to match the current version being used by the AzNet team.

Signed-off-by: Kathryn Baldauf kabaldau@microsoft.com

@katiewasnothere katiewasnothere requested a review from a team July 9, 2021 18:15
@katiewasnothere
Copy link
Contributor Author

@dcantah in particular :)

@kevpar
Copy link
Member

kevpar commented Jul 9, 2021

One note: I would probably put this under internal/tools since it's a test binary.

cmd/networkagent/main.go Outdated Show resolved Hide resolved
cmd/networkagent/main.go Outdated Show resolved Hide resolved
cmd/networkagent/main.go Outdated Show resolved Hide resolved
cmd/networkagent/main.go Outdated Show resolved Hide resolved
cmd/networkagent/main.go Outdated Show resolved Hide resolved
cmd/networkagent/main.go Outdated Show resolved Hide resolved
cmd/networkagent/defs.go Outdated Show resolved Hide resolved
@dcantah
Copy link
Contributor

dcantah commented Jul 10, 2021

Thanks for making this btw ❤️ I'll keep the review up on Monday

@dcantah
Copy link
Contributor

dcantah commented Jul 13, 2021

I'm wondering how we could make some useful tests here.. We need to launch ncproxy and the test agent and make calls between them to have anything of value

@katiewasnothere
Copy link
Contributor Author

I'm wondering how we could make some useful tests here.. We need to launch ncproxy and the test agent and make calls between them to have anything of value

@dcantah I was planning for this to mostly be useful for devs when manually testing. I'm still trying to figure out how we should write tests for ncproxy.

@katiewasnothere katiewasnothere marked this pull request as ready for review August 25, 2021 20:31
@katiewasnothere katiewasnothere changed the title [Draft] Add test network agent for ncproxy dev work Add test network agent for ncproxy dev work Aug 25, 2021
@dcantah dcantah self-assigned this Sep 8, 2021
Copy link
Contributor

@dcantah dcantah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Don't think we need to hold off on this for much, think you'd rather have it in already. Misc. cleanup, some better signal handling, and some os.Exit removals that I'd like to see, but the rest looks fine (just push new commit and squash on check in and we're all good). Had a small q on an a new nns call that's added here also that I'd like an answer on.

@katiewasnothere katiewasnothere force-pushed the test_network_agent branch 3 times, most recently from 46c347b to 3054463 Compare October 8, 2021 20:52
Signed-off-by: Kathryn Baldauf <kabaldau@microsoft.com>
@dcantah
Copy link
Contributor

dcantah commented Oct 8, 2021

re-lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants