[Compatibility] Adding EXPIRETIME and PEXPIRETIME command #664
+520
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TalZaccai
changed the title
There is already a GarnetObjectType.Expire, why not use that one? |
TalZaccai
requested changes
Sep 19, 2024
| /// <summary> | ||
| /// Special type indicating EXPIRETIME command | ||
| /// </summary> | ||
| Expiretime = 0xf9, |
There was a problem hiding this comment.
Don't think that there's a need for these new types
| public unsafe GarnetStatus EXPIRETIME<TContext, TObjectContext>(ref SpanByte key, StoreType storeType, ref SpanByteAndMemory output, ref TContext context, ref TObjectContext objectContext, bool milliseconds = false) | ||
| where TContext : ITsavoriteContext<SpanByte, SpanByte, SpanByte, SpanByteAndMemory, long, MainSessionFunctions, MainStoreFunctions, MainStoreAllocator> | ||
| where TObjectContext : ITsavoriteContext<byte[], IGarnetObject, ObjectInput, GarnetObjectStoreOutput, long, ObjectSessionFunctions, ObjectStoreFunctions, ObjectStoreAllocator> | ||
| { |
There was a problem hiding this comment.
Why not simply call TTL and convert it to unix-time?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding EXPIRETIME and EXPIRETIME command to garnet
Open Question:
Expirationinstead ofEXPIRETIMEandPEXPIRETIME? The advantage will be that it will be a single generic implementation that can be reused for others in the future if required. The disadvantage is that there will be a slight performance penalty but no additional memory needed since values ofExpiration,EXPIRETIMEandPEXPIRETIMEarelongtype, so we can do in-place override the value after recomputing the required value.